Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle algorithm parameters upon substituting algorithms to alternatives #526

Open
jonrkarr opened this issue May 3, 2021 · 0 comments

Comments

@jonrkarr
Copy link

jonrkarr commented May 3, 2021

When alternative algorithms are substituted (e.g., LSODA --> CVODE), I think algorithm parameters should be ignored. While some algorithms do share KiSAO terms for parameters, I'm hesitant to apply values of parameters designed for other algorithms because the meaning of these parameters could be subtly, but importantly different for different algorithms.

Presently, tellurium applies algorithm parameters regardless which algorithm was requested in SED-ML and whether tellurium is going to execute the requested algorithm or a different one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant