-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp cloudformation templates for Cloudlogs module #106
Conversation
956ae60
to
d0bdd02
Compare
… Makefile to take into consideration ORG case
4a78fa2
to
e8df4cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So if I'm reading this correctly, after this change:
The single account (cloudlogs only) install will create:
- A cloudlogs Role & policy in this account
The org (cloudlogs only) install will create:
- A cloudlogs Role & policy in the management account only
The single (cloudlogs + CSPM) is unchanged, and will create:
- A cloudlogs Role & policy in this account
- A cspm Role & policy in this account
The org (cloudlogs + CSPM) will create:
- a cspm role & policy in every account
- a cloudlogs role & policy in only the management account
Noting that this will need changes in the cloudauth BE to encode the new template/changed template names
Correct ✅
In this case we are also creating a
Correct ✅
Correct ✅
Yep, there's an open PR about that where we change the references according to the changes made in this PR :) |
Perfect! That makes sense to me, thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Revamp
CloudLogs
templates in order to provision all the necessary resoruces to fully support the organizational case. Now the end result is the same as applying the alternativeterraform
module(s).Note that, before this change, only one
CloudLogs
template was used for both theSingle
andOrganization
case, while an additional role needed to be provisioned in theOrganizational
case for Sysdig's systems to properly work. This means that also theMakefile
taking care of publishing the templates has been updated accordingly, along with the necessary changes in Sysdig's backend.