Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modular templates #127

Merged
merged 11 commits into from
Sep 3, 2024
Merged

modular templates #127

merged 11 commits into from
Sep 3, 2024

Conversation

cgeers
Copy link
Contributor

@cgeers cgeers commented Aug 21, 2024 •
edited
Loading

adds modular cloudformation templates integrating with the full sysdig secure feature set.

@cgeers cgeers requested review from a team as code owners August 21, 2024 21:50
@cgeers cgeers marked this pull request as draft August 26, 2024 23:13
@cgeers cgeers force-pushed the modular_templates branch 13 times, most recently from 5dbbcab to fdcf0a6 Compare August 27, 2024 21:08
@cgeers cgeers force-pushed the modular_templates branch 2 times, most recently from 894273b to 33c36df Compare August 28, 2024 22:10
@cgeers cgeers force-pushed the modular_templates branch 4 times, most recently from 670632b to e226c3a Compare August 29, 2024 20:35
@cgeers cgeers marked this pull request as ready for review August 29, 2024 20:35
nkraemer-sysdig
nkraemer-sysdig reviewed Aug 30, 2024
View reviewed changes
.github/workflows/ci-modules.yaml Show resolved Hide resolved
modules/Makefile Outdated Show resolved Hide resolved
@cgeers
feat(modules): consolidate ci
e9c7988 
* rolls up all modules into single CI workflow
* extend deploy target for all modules
ravinadhruve10
ravinadhruve10 reviewed Aug 30, 2024
View reviewed changes
Copy link
Contributor

@ravinadhruve10 ravinadhruve10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments. How are these components json files consumed?

modules/foundational.cft.yaml Outdated Show resolved Hide resolved
modules/foundational.cft.yaml Outdated Show resolved Hide resolved
modules/foundational.comoponents.json Outdated Show resolved Hide resolved
modules/log_ingestion.events.cft.yaml Outdated Show resolved Hide resolved
modules/log_ingestion.s3.cft.yaml Show resolved Hide resolved
modules/volume_access.cft.yaml Outdated Show resolved Hide resolved
ravinadhruve10
ravinadhruve10 approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@ravinadhruve10 ravinadhruve10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes, lgtm!

@cgeers cgeers merged commit 633fc29 into main Sep 3, 2024
3 checks passed
@cgeers cgeers deleted the modular_templates branch September 3, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravinadhruve10 ravinadhruve10 ravinadhruve10 approved these changes

@nkraemer-sysdig nkraemer-sysdig nkraemer-sysdig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cgeers @nkraemer-sysdig @ravinadhruve10