feat: Propagate ECS Service tags to tasks #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Appreciate the change @nkraemer-sysdig , thank you! |
mike-craig
reviewed
Jun 27, 2023
| @@ -16,6 +16,7 @@ resource "aws_ecs_service" "service" { | |||
| task_definition = aws_ecs_task_definition.task_definition.arn | |||
| wait_for_steady_state = true | |||
| tags = var.tags | |||
| propagate_tags = "SERVICE" | |||
There was a problem hiding this comment.
The AWS Terraform provider currently only supports propagation of tags from either the SERVICE or TASK_DEFINITION: https://registry.terraform.io/providers/hashicorp/aws/5.0.1/docs/resources/ecs_service#propagate_tags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #176 (Thanks @jmuthalaly for the suggestion)
Resource tags defined in the top level snippets were applied to the ECS Service, but not propagated to the Tasks. This change will allow tags to be set on the Tasks by configuring
var.tagsin the examples.