-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat (team service account) Manage Team Based Service Account as Terraform resource #386
Conversation
@@ -0,0 +1,97 @@ | |||
//go:build tf_acc_sysdig_monitor || tf_acc_sysdig_secure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the feature available for IBM?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now we don't support team service account in IBM envs.
|
||
func teamServiceAccountFromResourceData(d *schema.ResourceData) *v2.TeamServiceAccount { | ||
return &v2.TeamServiceAccount{ | ||
Name: d.Get("name").(string), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change here as well
} | ||
|
||
func teamServiceAccountToResourceData(teamServiceAccount *v2.TeamServiceAccount, d *schema.ResourceData) error { | ||
err := d.Set("name", teamServiceAccount.Name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
78a916a
to
8ec5225
Compare
This PR adds support for managing team service account via
sysdig_team_service_account
resource for both monitor and secure teams.