-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PROXYSQL FLUSH LOGS forces debug database flush #4833
Open
renecannao
wants to merge
12
commits into
v3.0
Choose a base branch
from
v3.0-flush_debug
base: v3.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also increased barching size from 31 to 100
Error handling for 'sqlite3_step' should be performed in a similar fashion as for 'sqlite3_exec'. Not handling these potential errors could result in invalid empty/incomplete resultsets when reading from the internal SQLite3 databases.
This new entry allows to associate session, thread and query being processed, and offers some extra details about the query itself.
- Fixed issue with SQLite3 helper functions. Invalid use of 'sqlite3_step' lead to fixing issue in ProxySQL itself. - Fixed logic issues on tests checking duplicated conditions. - Improved waiting logic checking for new entries in debug database. - Added new utility functions for SQLite3 databases access (debug database) following MySQL utilities conventions. - Simplified interface in several utilities functions with new, and more explicit naming convention.
Previously 'test_auth_methods' flagged a current ProxySQL limitation regarding auth full-handshakes with an error. This has been replaced with a warning until fixed.
By default 'get_proxysql_cpu_usage' now uses the currently configured interval for measuring system CPU usage ('admin-stats_system_cpu'). A parameter still allows to use a custom configured interval, but since maximum resolution is used for testing environments, the default value should normally be the one used.
…lgorithm-t.cpp' More queries were received during testing ('stats' user) that matched the previous check criteria. Warmup queries should now be uniquely identified with the test itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
PROXYSQL FLUSH LOGS
will also trigger the flushing of the debug database , if enabled.Also increased batching size from 31 to 100