Remove unused variable and fix command prompt display issue #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`prompt_flag` in `console.c` is specified as static and the only usage is the if statement at line 583 and the only assignment to it is at line 588 which assigns 1 to `prompt_flag`. Since no other code can modify this variable, it can be removed.
Commit dd6a761 removes `set_echo(0)` when `infd` is not the standard input, which will show command prompt while executing command from input files. Adding it back fixes the issue.
|
When mentioning a commit, besides referencing the commit SHA-1 ID, including the commit's subject title will make the description clearer, such as b13335b ("Introduce eventmux callback function for linenoise"). |
|
Refine the subject of this issue, making it informative. |
millaker
changed the title
console.c
|
When describing changes, it is not advisable to mention commit IDs that have not yet been merged into the upstream, as they are highly likely to be altered, rendering the description invalid. However, when referring to a commit already merged into the upstream, it should be mentioned using its SHA-1 ID along with a one-line summary of the commit. |
|
Split the proposed changes into two pull requests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit ("Remove unused variable") removes an unused variable in
console.c.prompt_flaginconsole.cis specified as static and the only usage is the if statement at line 583 and the only assignment to it is at line 588 which assigns 1 toprompt_flag. Since no other code can modify this variable, it can be removed.Commit ("Fix command prompt showing when using file input") fixes command prompt display issue when using file as input. Commit b13335b ("Introduce eventmux callback function for linenoise") removes
set_echo(0)wheninfdis not the standard input, which will show command prompt while executing command from input files. Adding it back fixes the issue.