feat:add deepin distribution #3253
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description: Log:
behrmann
reviewed
Dec 2, 2024
Comment on lines
+199
to
+208
| if ( | ||
| d | ||
| in { | ||
| Distribution.debian, | ||
| Distribution.deepin, | ||
| Distribution.ubuntu, | ||
| Distribution.kali, | ||
| } | ||
| and version_codename | ||
| ): |
There was a problem hiding this comment.
Suggested change
| if ( | |
| d | |
| in { | |
| Distribution.debian, | |
| Distribution.deepin, | |
| Distribution.ubuntu, | |
| Distribution.kali, | |
| } | |
| and version_codename | |
| ): | |
| if d and d.is_apt_distribution() and version_codename: |
Comment on lines
+173
to
+175
| def detect_distribution( | ||
| root: Path = Path("/"), | ||
| ) -> tuple[Optional[Distribution], Optional[str]]: |
There was a problem hiding this comment.
Please don't change this if it is not needed.
There was a problem hiding this comment.
This copies the debian.py quite fully, which would be a maintenance burden long term. Can you have a look at kali.py for a pointer how to implement a Debian derivative?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add deepin Root File System Creation with mkosi Support Starting from deepin v20 (Apricot).
Users can now utilize mkosi to build the root file systems for both deepin v20 (Apricot) and v23 (Beige). Here's how:
For deepin in v20 (Apricot):
For deepin v23 (Beige) specifically, with the repository mirror:
Sidenote: In accordance with the deepin branding guidelines, the preferred usage is to start the name "deepin" with a lowercase 'd', akin to how "openSUSE" begins with a lowercase 'o'. Therefore, in this context, we have intentionally used "deepin" rather than "Deepin"—this is not a typographical error. :)