Always check tools for build at the same place #3300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's only check non-build verb tools early and check build verb tools at the same place regardless of whether the verb is build or not to keep things more consistent. As a side effect this allows building tools from source to do the build in sync scripts which is done in https://github.com/davide125/arcadeos/blob/main/mkosi.sync.
behrmann
approved these changes
Dec 23, 2024
|
Tested in an ubuntu 24.04 container and it seems to work as expected, thanks! Related to this, it might make sense to also push some path validation down to when it's actually needed (specifically |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's only check non-build verb tools early and check build verb tools at the same place regardless of whether the verb is build or not to keep things more consistent.
As a side effect this allows building tools from source to do the build in sync scripts which is done in
https://github.com/davide125/arcadeos/blob/main/mkosi.sync.