Skip to content

Commit

Permalink
Polish settings page
Browse files Browse the repository at this point in the history
  • Loading branch information
t-hamano committed Oct 17, 2024
1 parent 5aeadbb commit ad73baf
Show file tree
Hide file tree
Showing 2 changed files with 39 additions and 23 deletions.
58 changes: 35 additions & 23 deletions src/admin/editor-config/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -210,12 +210,14 @@ export default function EditorConfig() {
<EditorOptions.MinimapEnabled />
{ ! editorOptions.minimap.enabled ? (
<Disabled>
<EditorOptions.MinimapSide />
<EditorOptions.MinimapMaxColumn />
<EditorOptions.MinimapScale />
<EditorOptions.MinimapShowSlider />
<EditorOptions.MinimapSize />
<EditorOptions.MinimapRenderCharacters />
<VStack spacing={ 4 }>
<EditorOptions.MinimapSide />
<EditorOptions.MinimapMaxColumn />
<EditorOptions.MinimapScale />
<EditorOptions.MinimapShowSlider />
<EditorOptions.MinimapSize />
<EditorOptions.MinimapRenderCharacters />
</VStack>
</Disabled>
) : (
<>
Expand Down Expand Up @@ -258,11 +260,13 @@ export default function EditorConfig() {
<EditorOptions.Folding />
{ ! editorOptions.folding ? (
<Disabled>
<EditorOptions.ShowFoldingControls />
<EditorOptions.FoldingStrategy />
<EditorOptions.LineDecorationsWidth />
<EditorOptions.FoldingHighlight />
<EditorOptions.UnfoldOnClickAfterEndOfLine />
<VStack spacing={ 4 }>
<EditorOptions.ShowFoldingControls />
<EditorOptions.FoldingStrategy />
<EditorOptions.LineDecorationsWidth />
<EditorOptions.FoldingHighlight />
<EditorOptions.UnfoldOnClickAfterEndOfLine />
</VStack>
</Disabled>
) : (
<>
Expand All @@ -284,9 +288,11 @@ export default function EditorConfig() {
<EditorOptions.LineNumbers />
{ 'off' === editorOptions.lineNumbers ? (
<Disabled>
<EditorOptions.LineNumbersMinChars />
<EditorOptions.SelectOnLineNumbers />
<EditorOptions.RenderFinalNewline />
<VStack spacing={ 4 }>
<EditorOptions.LineNumbersMinChars />
<EditorOptions.SelectOnLineNumbers />
<EditorOptions.RenderFinalNewline />
</VStack>
</Disabled>
) : (
<>
Expand All @@ -306,11 +312,13 @@ export default function EditorConfig() {
<EditorOptions.QuickSuggestions />
{ ! editorOptions.quickSuggestions ? (
<Disabled>
<EditorOptions.AcceptSuggestionOnEnter />
<EditorOptions.QuickSuggestionsDelay />
<EditorOptions.SuggestFontSize />
<EditorOptions.SuggestLineHeight />
<EditorOptions.SuggestShowIcons />
<VStack spacing={ 4 }>
<EditorOptions.AcceptSuggestionOnEnter />
<EditorOptions.QuickSuggestionsDelay />
<EditorOptions.SuggestFontSize />
<EditorOptions.SuggestLineHeight />
<EditorOptions.SuggestShowIcons />
</VStack>
</Disabled>
) : (
<>
Expand Down Expand Up @@ -422,8 +430,10 @@ export default function EditorConfig() {
<EditorOptions.ScrollbarHorizontal />
{ 'hidden' === editorOptions.scrollbar.horizontal ? (
<Disabled>
<EditorOptions.ScrollbarHorizontalHasArrows />
<EditorOptions.ScrollbarHorizontalScrollbarSize />
<VStack spacing={ 4 }>
<EditorOptions.ScrollbarHorizontalHasArrows />
<EditorOptions.ScrollbarHorizontalScrollbarSize />
</VStack>
</Disabled>
) : (
<>
Expand All @@ -434,8 +444,10 @@ export default function EditorConfig() {
<EditorOptions.ScrollbarVertical />
{ 'hidden' === editorOptions.scrollbar.vertical ? (
<Disabled>
<EditorOptions.ScrollbarVerticalHasArrows />
<EditorOptions.ScrollbarVerticalScrollbarSize />
<VStack spacing={ 4 }>
<EditorOptions.ScrollbarVerticalHasArrows />
<EditorOptions.ScrollbarVerticalScrollbarSize />
</VStack>
</Disabled>
) : (
<>
Expand Down
4 changes: 4 additions & 0 deletions src/admin/editor-config/style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@
max-width: 300px;
}

.components-toggle-control {
max-width: 300px;
}

.chbe-admin-editor-config__settings {
flex: 1;
}
Expand Down

0 comments on commit ad73baf

Please sign in to comment.