A11y #55
Open
A11y #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure you do the following before filing your PR:
Provide a video or screenshots of any visual changes made
Addresses Issue Keyboard/Screen-reader support #51 Keyboard/Screen-reader support #51
Run
pnpm run checkand make sure everything passesRemoved
<span>in upload button and gave it a labelGave keyboard focus to the upload label
Improved contrast for 'View on GitHub" button.
I tested this on NVDA, Chrome, and Windows using Axe DevTools to scan each page.
I would like to eventually implement Axe React Core as a linter in github workflow so it scales better with more contributions. More info here: https://www.npmjs.com/package/@axe-core/react