Remove support php 7.3 (#32)

tabuna · Oct 20, 2021 · bca3257 · bca3257
1 parent 4109765
commit bca3257
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 6 deletions.
diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml
@@ -12,7 +12,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        php: [8.0, 7.4, 7.3]
+        php: [8.0, 7.4]
         laravel: [8.*]
         dependency-version: [prefer-lowest, prefer-stable]
         include:

diff --git a/composer.json b/composer.json
@@ -17,6 +17,7 @@
         }
     ],
     "require": {
+        "php": "^7.4|^8.0",
         "ext-json": "*",
         "laravel/framework": "^8.16",
         "laravel/serializable-closure": "^1.0"

diff --git a/src/BreadcrumbsMiddleware.php b/src/BreadcrumbsMiddleware.php
@@ -57,11 +57,7 @@ public function handle(Request $request, Closure $next)
                 /** @var SerializableClosure $callback */
                 $callback = unserialize($serialize);
 
-                if (is_a($callback, SerializableClosure::class)) {
-                    $callback = $callback->getClosure();
-                }
-
-                $this->breadcrumbs->for($route->getName(), $callback);
+                $this->breadcrumbs->for($route->getName(), $callback->getClosure());
             });
 
         optional($request->route())->forgetParameter(self::class);