Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: better decompilation of ADD and MUL ops #29

Merged
merged 1 commit into from
Jan 17, 2025
Merged

fix: better decompilation of ADD and MUL ops #29

merged 1 commit into from
Jan 17, 2025

Conversation

i582
Copy link
Contributor

@i582 i582 commented Jan 17, 2025

  • 10 ADD as 10 ADDCONST
  • -1 ADD as DEC
  • -1 MUL as NEGATE

Fixes #25

@i582 i582 changed the title fix: better decompile ADD and MUL ops fix: better decompilation of ADD and MUL ops Jan 17, 2025
@i582 i582 requested a review from anton-trunov January 17, 2025 09:11
@anton-trunov anton-trunov requested a review from Shvandre January 17, 2025 10:20
Shvandre
Shvandre approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@Shvandre Shvandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Shvandre Shvandre merged commit a2939ea into main Jan 17, 2025
3 checks passed
@Shvandre Shvandre deleted the pmakhnev/better-decompile-add-mul-ops branch January 17, 2025 13:43
@anton-trunov anton-trunov mentioned this pull request Jan 17, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shvandre Shvandre Shvandre approved these changes

@anton-trunov anton-trunov Awaiting requested review from anton-trunov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ADDCONST being printed like ADD
2 participants
@i582 @Shvandre