Feature/5/new integration authentication #14
Conversation
ahmedasad236
commented
Sep 4, 2023
ahmedasad236
commented
- Create the UI of the authentication page of new integration feature
- Create the layout of the page. - Add the route of the page to the existed routes.
- Create the page that you choose from it the authentication type
- Create the first step component of API-KEY authentication
- Create the UI form of the new field authentication
- Change the page of NewAuthField and make the form as a modal.
…endpoint and the headers
package.json
Outdated
| "dependencies": { | ||
| "@emotion/react": "^11.11.1", | ||
| "@emotion/styled": "^11.11.0", | ||
| "@mui/joy": "^5.0.0-beta.3" |
There was a problem hiding this comment.
@ahmedasad236 please remove unused packages
| import WrappingBox from "components/WrappingBox" | ||
| import { useState } from "react" | ||
|
|
||
| export type field = { |
There was a problem hiding this comment.
good to define types, if we have defined a lot of types, can move them into separate file.
Automatisch already did that, check this path "/packages/types/index.d.ts"
|
|
||
| function TagNumber({text}:TagNumberProps) { | ||
| return ( | ||
| <Box sx={{width: '10%', mr: '1rem', borderRadius: '100px', backgroundColor:'#001F52', color: '#fff', textAlign: 'center', p: 1, fontSize: '14px', fontWeight: '500'}}>{text}</Box> |
There was a problem hiding this comment.
instead of making separate components for just adding styles, we can define a class with these styles and just use it in the class attribute.
There was a problem hiding this comment.
this is for tagNumber and wrapping box as well.
There was a problem hiding this comment.
in automatisch they do not use CSS as separated files.
So, I used this approach.
But no problem, I will do this
|
|
||
| const form = useForm<field>(); | ||
| const { register, getValues } = form; | ||
|
|
There was a problem hiding this comment.
why we're not using this instead of fieldState?
- Refactor the components design: make the fields in one form
…:tactful-ai/Dstny-Integrator-Hub into feature/5/new_integration_authentication
ahmedasad236
force-pushed
the
feature/5/new_integration_authentication
branch
from
47fcf0f to
3fe8514
Compare
