Skip to content

Commit

Permalink
Remove superfluous cache step (#2104)
Browse files Browse the repository at this point in the history
The maintainers of actions/cache recommend not caching node_modules. See
https://github.com/actions/cache/blob/main/examples.md#node---npm Also,
it never hits the cache
  • Loading branch information
mattwr18 authored Jan 28, 2025
1 parent bddcd58 commit b15eaa6
Showing 1 changed file with 3 additions and 10 deletions.
13 changes: 3 additions & 10 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
timeout-minutes: 15

env:
RUBYOPT: "-W:no-deprecated"
RUBYOPT: '-W:no-deprecated'
RAILS_ENV: test
DATABASE_URL: postgres://postgres:postgres@localhost:5432

Expand All @@ -19,7 +19,7 @@ jobs:
POSTGRES_USER: postgres
POSTGRES_PASSWORD: postgres
POSTGRES_DB: app_test
ports: [ "5432:5432" ]
ports: ['5432:5432']
options: --health-cmd pg_isready --health-interval 10s --health-timeout 5s --health-retries 5

steps:
Expand All @@ -38,16 +38,9 @@ jobs:
- name: Install ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ steps.versions.outputs.ruby}}
ruby-version: ${{ steps.versions.outputs.ruby}}
bundler-cache: true

- name: Cache NPM dependencies
uses: actions/[email protected]
with:
path: node_modules
key: ${{ runner.os }}-npm-${{ hashFiles('**/package-lock.json') }}
restore-keys: ${{ runner.os }}-npm-

- name: Install NPM dependencies
run: npm install

Expand Down

0 comments on commit b15eaa6

Please sign in to comment.