fix: flaky spec

[roschaefer]

Motivation

Also this took me way too long to fix. #1729 suffers under some unrelated failing spec. On my machine, even when I git switch main on the 07694a6 I will see sometimes a failing spec, sometimes it passes.

Here is an example:

  1) Configuring Onboarding Channels allows activating and deactivating onboarding channels
     Failure/Error: expect(page).to have_current_path(settings_path(as: admin))
       expected "/settings" to equal "/settings?as=177"

     [Screenshot Image]: tmp/screenshots/failures_r_spec_example_groups_configuring_onboarding_channels_allows_activating_and_deactivating_onboarding_channels_617.png

     # ./spec/system/settings/onboarding_channels_spec.rb:26:in `block (2 levels) in <main>'
     # ./spec/support/better_rails_system_tests.rb:26:in `block (2 levels) in <main>'
     # -e:1:in `<main>'

I don't think it is necessary to check the query params here, maybe it was even an oversight. What I still don't understand: What is some_route_path(as: some_user) even doing? And why did it work in the past?

How to test

1. git switch main
2. bin/rspec spec/system/settings/onboarding_channels_spec.rb multiple (!) times
3. Sometims green, sometimes red

This should not happen on this branch anymore.

[mattwr18]

I don't have any problem with this change as long as it works. I have not seen that this has been flaky, it has actually never failed for me either locally or in ci. I believe at some point I was getting failing tests for not having the search params, so I added it to get the test to pass.

The as: user comes from our gem user management gem clearance. See Fast Feature Specs.

There are a few other places in the specs where I have made similar assertions, were none of them flaky? I am wondering if the test in question was actually flaky for the reason you think it was.

If it is flaky for the reason you suggest, I would expect the other specs to be flaky as well. Maybe this PR should update them as well?