-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(AL-885): Revamped documentation #19
base: master
Are you sure you want to change the base?
Conversation
- refactor: rename socket client to not reflect the protocol.
…rtant stages of the connection.
General FeedbackOverall, the documentation needs significant improvements to enhance clarity and cohesion. Currently, it feels disjointed, and the steps are hard to follow. It's crucial to ensure that each step is connected and that the examples are presented as cohesive programs rather than isolated snippets within the Python interpreter. I had left the following feedback to @Edu-B in AL-887 Here are the key questions the documentation should address:
Additionally, there's information missing related to real-time notifications. This PR/Jira issue was previously blocked due to Marlyn working on the feature, but as I understand, the feature is now complete. Code Formatting TipsTo improve the readability and professionalism of the code examples, please follow these formatting guidelines:
These tips will help in creating a more professional and user-friendly documentation that is easier to follow and understand. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow up feedback comments and update.
|
||
## Installation | ||
|
||
To integrate the Alfred python library into your python project, install the package via Pypy: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's pypi not pypy
@@ -19,64 +54,130 @@ auth_config = {"api_key": "AXXXXXXXXXXXXXXXXXXXXXX"} | |||
|
|||
client = AlfredClient(config, auth_config) | |||
|
|||
values = client.data_points.get_values("XXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXX") | |||
print(values) | |||
result = client.sessions.create() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would I want to create a session to get started? I think that a call to who am I is the proper way to "confirm" you are authenticated.
>>> result = client.sessions.get("XXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXX") | ||
>>> print(result) | ||
|
||
{'id': '3386f840-74e2-4bd8-92a7-57e829e46d05', 'creation_date': '2024-05-10T20:32:43.85', 'update_date': '2024-05-10T20:32:43.85', 'status': 'open', 'user_name': 'API Key 1', 'company_id': '286e2ed0-3626-4faa-a745-8ebf3488fbd7', 'job_id': None} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When showing dictionaries or JSON results, please "prettify" them rather than placing them in a single line.
Jira Ticket: AL-885
Changes
README Updated: - The README provides a brief overview of the library and its key features.
- Includes links to more detailed documentation sections.
Authentication Methods Documented:
Clear documentation on the three login methodologies.
File Upload Documentation extended:
The file upload process is documented in a step-by-step guide with corresponding code examples.
Real-Time Engine Usage:
Documentation includes instructions on initializing and using the real-time engine.
Code Examples and Clarity:
All documentation has relevant code examples that are tested and verified to work.
Language used in the documentation is clear, concise, and free of jargon where possible.
Community Contribution Guidelines:
There is a section encouraging and guiding community contributions, including detailed steps for contributing.