-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(AL-901): Updated README info #9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the README is more streamlined, however I am worried there is no example on how initialize a Deferred Session and how to retrieve the information.
There are some sections that where not completely removed from previous versions, I marked them accordingly.
As a general note: we need to reduce the amount of adjectives we use in this types of documents (quick, robust, powerful, streamlined, etc.) they might be useful in more customer oriented docs but not so much for technical documents like this one.
All the content has been adjusted as per my first example in my first commit to the PR. All the endpoints are documented, with clear copy paste examples and brief descriptions. An outsider should be able to follow the use of the library without issues. Please give me all the feedback that you can, if this structure holds to our standard then its the template we are going to use to document the other 2 libraries. |
Thank you for the thorough effort in improving the documentation for this library, especially given that it is a public one. This is definitely a step in the right direction. I do have a couple of suggestions to enhance it further:
Your efforts are much appreciated, and these adjustments will help make the documentation even more valuable to our users. |
In my last commit I removed the examples in the blocks of code in the |
Co-authored-by: Mateh Elismar <[email protected]>
🎉 This issue has been resolved in version 0.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Jira Ticket: AL-901
Changes