Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AL-901): Updated README info #9

Merged
merged 5 commits into from
Jul 6, 2024
Merged

Conversation

MiguelTapTagshelf
Copy link
Contributor

@MiguelTapTagshelf MiguelTapTagshelf commented Jun 5, 2024

Jira Ticket: AL-901

Changes

  • Updated README info to reflect a more cohesive version of the same type of info. The step by step guides have been removed and they have been replaced by an explanation of the operations that the library provides, followed by clear snippets of code examples that can be copied and tested locally.

@MiguelTapTagshelf MiguelTapTagshelf requested a review from rroa June 5, 2024 23:17
@MiguelTapTagshelf MiguelTapTagshelf self-assigned this Jun 5, 2024
README.md Outdated Show resolved Hide resolved
Copy link

@ejtorresm ejtorresm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the README is more streamlined, however I am worried there is no example on how initialize a Deferred Session and how to retrieve the information.

There are some sections that where not completely removed from previous versions, I marked them accordingly.

As a general note: we need to reduce the amount of adjectives we use in this types of documents (quick, robust, powerful, streamlined, etc.) they might be useful in more customer oriented docs but not so much for technical documents like this one.

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@MiguelTapTagshelf MiguelTapTagshelf marked this pull request as ready for review June 28, 2024 23:49
@MiguelTapTagshelf MiguelTapTagshelf requested a review from a team as a code owner June 28, 2024 23:49
@MiguelTapTagshelf
Copy link
Contributor Author

@ejtorresm @rroa

All the content has been adjusted as per my first example in my first commit to the PR. All the endpoints are documented, with clear copy paste examples and brief descriptions. An outsider should be able to follow the use of the library without issues.

Please give me all the feedback that you can, if this structure holds to our standard then its the template we are going to use to document the other 2 libraries.

ejtorresm
ejtorresm previously approved these changes Jul 1, 2024
@rroa
Copy link
Contributor

rroa commented Jul 5, 2024

@MiguelTapTagshelf

Thank you for the thorough effort in improving the documentation for this library, especially given that it is a public one. This is definitely a step in the right direction. I do have a couple of suggestions to enhance it further:

  1. Remove Results from C# Example Executions: The results included in the C# example executions seem to distort the actual response from the API. Removing these will make the examples clearer and more accurate.

  2. Add Reference to HTTP API Documentation: Since this library serves as a wrapper for our HTTP API, it would be beneficial to include a reference to our HTTP API documentation. This will provide users with a more comprehensive understanding of how the library interacts with the API.

Your efforts are much appreciated, and these adjustments will help make the documentation even more valuable to our users.

@MiguelTapTagshelf
Copy link
Contributor Author

In my last commit I removed the examples in the blocks of code in the README file and added the reference to the http docs in the overview section.

README.md Outdated Show resolved Hide resolved
Co-authored-by: Mateh Elismar <[email protected]>
@MiguelTapTagshelf MiguelTapTagshelf merged commit bd2991a into development Jul 6, 2024
1 check passed
@MiguelTapTagshelf MiguelTapTagshelf deleted the fix/AL-901 branch July 6, 2024 22:28
Copy link

🎉 This issue has been resolved in version 0.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants