🪄 [QA] Update stage environments #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
The previous solution had an edge case where, if the target address was in the last file in the glossary, we would instead look for them in the first file and fail to find the claim. We transition here from `findIndex` to `find`. We stop looking when the *next* entry in the glossary has a startAddress > the target. We also stop looking at the last entry in the glossary regardless, and always check the last entry if no entry is found whose sibling has start > target. This *should* cover all corner cases correctly.
…in the last file of the glossary. (#624) The previous solution had an edge case where, if the target address was in the last file in the glossary, we would instead look for them in the first file and fail to find the claim. We transition here from `findIndex` to `find`. We stop looking when the *next* entry in the glossary has a startAddress > the target. We also stop looking at the last entry in the glossary regardless, and always check the last entry if no entry is found whose sibling has start > target. This *should* cover all corner cases correctly.
✅ Deploy Preview for taho-development ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jagodarybacka
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pull request that upon merging will update stage environments with recent
mainchanges.The environments that will be updated:
Read more: Deployment to Production Flow