-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🪄 [QA] Update stage environments #647
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wallet can't handle signing multiple transactions at once, we need to send them one by one and wait for the previous to either be signed or rejected.
Co-authored-by: Karolina Kosiorowska <[email protected]>
Having one state of `unclaimedDrops` while the claim modal is visible will provide better UX than updating it after each transaction.
Resolves #587 What has been done: - Added privacy policy to the DApp - Added reusable `Popup` component (used in privacy policy and `Assistant`)
✅ Deploy Preview for taho-development ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Resolves #606 ### What Wallet can't handle signing multiple transactions at once, we need to send them one by one and wait for the previous to either be signed or rejected. We achieve it by having separate claim buttons for each unclaimed drop This should be tested on [xp-testing env](#504), we should sync once to test it as a single person need to do the drops on the testing environment.
Resolves #634 <img width="702" alt="634" src="https://github.com/tahowallet/dapp/assets/28560653/d799d089-8a49-4eeb-bf70-ba1f1ddb8531">
Resolves #652 What has been done: - Moves `DApps` to ui folder - Video is only loaded when user is not onboarded
andreachapman
approved these changes
Nov 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved for stage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pull request that upon merging will update stage environments with recent
main
changes.The environments that will be updated:
Read more: Deployment to Production Flow