🪄 [QA] Update stage environments #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
As Andrea is leaving the project, I'm changing the reviewer of the deployment PRs to myself.
As Andrea is leaving the project, I'm changing the reviewer of the deployment PRs to myself.
✅ Deploy Preview for taho-development ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Make sure Reflect is initialized only once. Cleanup all Reflect hooks.
Refactor based on my comments from the PR #785 (comment) - Make sure Reflect is initialized only once. - Cleanup all Reflect hooks. ### Testing - [x] run dev server for reflect - it shouldn't throw any errors - [x] try Reflect feature in the UI - [x] check if you can disable Reflect with the feature flag - [x] test hooks if they are running when they should (you can put `console.logs` on each reflect mutate)
PR fixing reflect issues
`component=RoomDO
doID=2c6330d03afb624a4ff346e2b01457962428cab1cb8309ea070a7e3ca08525d5
roomID=/ wsid=H6hCaalCugPRmK_fFp0LY
clientID=35af2e3b-99f9-4ba5-8176-522d9b231114
clientGroupID=d36a9504-f10f-4ca7-80de-f1418677e953
userID=_tje_WNFe00VnTez25Yh6 network.client.ip=79.143.107.106
http.useragent=Mozilla/5.0 (Windows NT 10.0; Win64; x64)
AppleWebKit/537.36 (KHTML, like Gecko) Chrome/119.0.0.0 Safari/537.36
lockFn=handleConnection lockHoldID=21ov719ob9w WebSocket ErrorEvent for
client 35af2e3b-99f9-4ba5-8176-522d9b231114
{"filename":"","message":"Uncaught Error: Network connection
lost.","lineno":0,"colno":0} {"name":"Error","message":"Network
connection lost.","stack":"Error: Network connection lost."}`
`[skipping unknown mutator, {args=true,
clientID=4f29a6e6-e394-4897-90bc-824874dcef98,
clientGroupID=8d2b220c-cad3-4423-ba53-68dbc1ee3000, auth={userID=****},
timestamps={serverReceivedTimestamp=1700822826238,
originTimestamp=1700822827090, normalizedTimestamp=1700822826464},
name=setUserPresence, id=6}]`
**What has been done:**
- Moved reflect instance to client-side
- Validating data using `zod` package
## What has been done: - We were accidentally displaying avatar urls as names 🙈 - Added `KonvaVideo` component to handle video on canvas - Added compatibilty with video as user avatar ## Testing - [x] Test with video avatar (example user `0xab7375daf14bc661a0c9aff8800d49a34b037a98`) - [ ] Test with image avatar
Resolves #790   ## What has been done: - Added line to map between Base and Arbitrum realm - Added vampire attack label to modal - Updated `questline-data.json`: new quest added, removed `isNew` label from previously added quests - Removed "new realm" label from Base Realm ## Testing - [x] Clear `localStorage` - [x] Check if vampire attack border line is positioned correctly - [x] Check if "new quest" start label is displayed in the Base realm - [x] Open modal and open vampire quest accordion - check if the start disappeared from map
jagodarybacka
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pull request that upon merging will update stage environments with recent
mainchanges.The environments that will be updated:
Read more: Deployment to Production Flow