Correct dApp info passed on eth_requestAccounts #3768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Invalid params resulted in an empty array passed as dapp connection info
Shadowfiend
reviewed
Jan 18, 2025
| @@ -234,7 +234,6 @@ export default class ProviderBridgeService extends BaseService<Events> { | |||
| // methods). | |||
| const [title, faviconUrl] = (event.request.params as unknown[]).slice( | |||
| -2, | |||
| 0, | |||
There was a problem hiding this comment.
🤔 -2,0 and -2 alone should be synonymous. What's the difference in outcome?
There was a problem hiding this comment.
I thought that too but -2 means start from (array length + -2). So setting the end as 0 makes it return an empty array because the ending position is before the starting position
There was a problem hiding this comment.
Well that's embarrassing 😬
Shadowfiend
approved these changes
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was making one of the e2e test fail as an empty array was passed as dApp connection info.
To test
Latest build: extension-builds-3768 (as of Fri, 17 Jan 2025 22:18:50 GMT).