Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(browser): allow return null from beforeSend #20

Merged
merged 2 commits into from
Mar 29, 2024
Merged

fix(browser): allow return null from beforeSend #20

merged 2 commits into from
Mar 29, 2024

Conversation

sevaru
Copy link
Contributor

@sevaru sevaru commented Mar 29, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

beforeSend does not allow return of null to stop error processing

Closes #19

What is the new behavior?

Allow to beforeSend to return null

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@sevaru sevaru requested a review from MarsiBarsi as a code owner March 29, 2024 14:14
@sevaru sevaru requested a review from splincode March 29, 2024 14:14
splincode
splincode previously approved these changes Mar 29, 2024
@sevaru sevaru requested a review from splincode March 29, 2024 14:56
@splincode splincode merged commit bbd0664 into main Mar 29, 2024
3 checks passed
@splincode splincode deleted the 19 branch March 29, 2024 15:37
@taiga-family-bot
Copy link
Contributor

🎉 This pull request is included in version [email protected] 🎉

The release is available on GitHub release

@taiga-family-bot
Copy link
Contributor

🎉 This pull request is included in version [email protected] 🎉

The release is available on GitHub release

@taiga-family-bot
Copy link
Contributor

🎉 This pull request is included in version [email protected] 🎉

The release is available on GitHub release

@taiga-family-bot
Copy link
Contributor

🎉 This pull request is included in version [email protected] 🎉

The release is available on GitHub release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Allow return null from beforeSend
3 participants