fix(testing): jasmine async & done deprecation #1363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
Codecov Report
@@ Coverage Diff @@
## main #1363 +/- ##
=======================================
Coverage 64.64% 64.64%
=======================================
Files 766 766
Lines 8739 8754 +15
Branches 1741 1742 +1
=======================================
+ Hits 5649 5659 +10
- Misses 2673 2679 +6
+ Partials 417 416 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
splincode
reviewed
Feb 10, 2022
projects/addon-tablebars/components/table-bars-host/test/table-bars-host.component.spec.ts
Outdated
Show resolved
Hide resolved
splincode
reviewed
Feb 10, 2022
splincode
reviewed
Feb 10, 2022
splincode
reviewed
Feb 10, 2022
fixes according to PR comments
GinMitch
requested review from
waterplea,
MarsiBarsi,
vladimirpotekhin and
nsbarsukov
as code owners
waterplea
approved these changes
Feb 11, 2022
added 2 commits
February 11, 2022 13:23
migrated all tests to use the new helper
removed redundant packages
splincode
approved these changes
Feb 11, 2022
|
|
vladimirpotekhin
pushed a commit
that referenced
this pull request
Feb 17, 2022
* fix(testing): jasmine async & done deprecation * fix(testing): jasmine async & done deprecation fixes according to PR comments * fix(testing): jasmine async & done deprecation migrated all tests to use the new helper * fix(testing): jasmine async & done deprecation removed redundant packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #1299 as soon as all tests are migrated
Original issue: topnotch48/ng-bullet-workspace#38
What is the new behavior?
Does this PR introduce a breaking change?