-
Notifications
You must be signed in to change notification settings - Fork 125
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went quickly over some of the code, very superficial feedback for now.
Would be great if you could share whatever design documents you have for this circuit as well because that'll make it easier to understand and check against the code.
Blockhash: Some code refactoring
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think good to go to merge in the master in this branch (or apply your circuits on top of the master branch in another branch)!
That'll also make the reviewing a bit easier because now some of the code is shared with the old public input circuit. If all the anchor specific stuff is in its own sub-circuit it'll be easier to just focus on that. Of course also okay if you first want to do the 256 block hashes and then do the update to main.
I will merge in one go when finished with the previous hashes work. I'll add this work in this PR |
9a6939c
to
059d926
Compare
added solution for #107 |
MOVED TO #129 |
MOVED TO #129
### DescriptionIn-circuit blockhash calculation. Design documentation can be found here: https://www.notion.so/taikoxyz/In-circuit-blockhash-calculation-docs-069984cbc14446a9a1ea88387178e9ce### Issue Link[https://github.com//issues/79]### Type of change- [ ] Bug fix (non-breaking change which fixes an issue)- [x] New feature (non-breaking change which adds functionality)- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)- [ ] This change requires a documentation update