-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move tailwindcss from dependencies to peer dependencies #15751
Conversation
Hey! Appreciate the PR but we used a regular dependency for the fact that we need to ensure all Tailwind packages resolve to the same version. Are you running into any issues with this? I'm going to close this PR for now but if you run into any issues with this setup please let us know. |
@philipp-spiess Using Tailwind as peer dependency, the installed version is respected. Some example, having a package manager with the dedupe-dependencies-on-install option disabled.
|
Thanks, but I still don't understand what the issue is with using a regular dependency? In your PR you pinned the peer dependency to a broad version range ( |
You should be able to install install:
In
With peer dependency |
@rtritto I see. Just to clarify: We do not want you to use |
Ok, the release workflow should release all package at same time:
So, in the {
"name": "@tailwindcss/vite",
"version": "4.0.0",
"peerDependencies": {
"tailwindcss": "workspace:*"
}
} By this way, you need to update both
|
@philipp-spiess I did the changes in the commit rtritto@ee786ce FYI @RobinMalfait |
No description provided.