Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering Images by Text Field #476

Merged
merged 2 commits into from
Sep 7, 2024

Conversation

sanao1006
Copy link
Contributor

@sanao1006 sanao1006 commented Sep 7, 2024

Overview

Installed TextField to allow narrowing down the image in the displayed screenshot.

The location of the text field is tentative, so if you have a request, please let me know where you would like to place it.

Fixed #475

video

video_filter.mov

@@ -160,6 +165,22 @@ class RoborazziPreviewPanel(project: Project) : JPanel(BorderLayout()) {
anchor = GridBagConstraints.WEST
insets = JBUI.insets(4)
})
add((JBTextField().apply {
emptyText.text = "Enter screenshot name..."
Copy link
Contributor Author

@sanao1006 sanao1006 Sep 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a placeholder(hint text) for a text field.
I have inserted a tentative description, so please let me know if you have any requests for a description you would like inserted.

@sanao1006 sanao1006 marked this pull request as ready for review September 7, 2024 06:49
Copy link
Owner

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've downloaded the plugin build and tried it. It was great! Thank you for improving our test tooling and helping to enhance our test culture.

@takahirom takahirom merged commit b7a8bd9 into takahirom:main Sep 7, 2024
6 checks passed
@sanao1006
Copy link
Contributor Author

Thanks for your review!!!!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filtering Images by Text Field in IntelliJ Plugin
2 participants