Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial integration of differ to support iOS #496

Conversation

eyedol
Copy link
Contributor

@eyedol eyedol commented Oct 2, 2024

Fixes #383

Copy link
Owner

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for coordinating with other libraries and advancing our library foundation.
@eyedol, do you have anything to add to make this PR ready?

@eyedol
Copy link
Contributor Author

eyedol commented Oct 6, 2024

Looks great! Thank you for coordinating with other libraries and advancing our library foundation.
@eyedol, do you have anything to add to make this PR ready?

I was going to look into how to use RoboCanvas to make an iOS implementation similar to how it's done with AwtRoboCanvas however, I couldn't figure out where to begin. Basically I wanted to work on the comments in RoborazziIos.kt

This is a temporary implementation for iOS.
We need to transition these implementations to Kotlin Multiplatform and RoboCanvas....

If you could point me in the right direction what you wanted to achieve with the comments in there, that would be great. Also if you think it will be a huge change in the end, we can tackle it with another PR. Let me know. Thanks.

@takahirom
Copy link
Owner

I think gradually moving the code to commonMain without using it for iOS will allow us to make progress without bugs, and then we can finally use it for iOS.

@eyedol eyedol changed the title [DRAFT] Initial integration of differ snapshot releases to support iOS Initial integration of differ to support iOS Oct 7, 2024
@eyedol eyedol force-pushed the eyedol/migrateIosImplementationToUseRoboCanvasInterface branch from 46f7d77 to e808d87 Compare October 7, 2024 14:25
@eyedol eyedol marked this pull request as ready for review October 7, 2024 14:25
@takahirom
Copy link
Owner

Thank you for your contribution!

@takahirom takahirom merged commit 828760f into takahirom:main Oct 8, 2024
6 checks passed
@eyedol eyedol deleted the eyedol/migrateIosImplementationToUseRoboCanvasInterface branch October 8, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate iOS implementation to use RoboCanvas Interface
2 participants