Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve the performance of the image bubble #220

Merged
merged 3 commits into from
Oct 20, 2023
Merged

feat: improve the performance of the image bubble #220

merged 3 commits into from
Oct 20, 2023

Conversation

githubdoandre
Copy link
Collaborator

@githubdoandre githubdoandre commented Oct 18, 2023 •
edited
Loading

This PR improve the performance of the image bubble, the image will be downloaded and then it is used to show in the bubble

Some improves:

  • Download the image and store it before shows to the user
  • After download the imagem, we are compress it to reduce the size and memory use
  • Added a progress loading in the message bubble to show the download progress of the image

See preview

@githubdoandre githubdoandre merged commit c2ee1a3 into develop Oct 20, 2023
1 check passed
@mpamaro mpamaro deleted the feature/540984-improve-image-bubble branch November 1, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpamaro mpamaro mpamaro approved these changes

@RaulRodrigo06 RaulRodrigo06 RaulRodrigo06 approved these changes

@leonardogbr leonardogbr Awaiting requested review from leonardogbr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@githubdoandre @RaulRodrigo06 @mpamaro