Migrate home page and CSV parsing logic #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've also taken the liberty of migrating the CSV uploading/parsing logic to a separate service. CSV parsing doesn't really fit into the MVC paradigm so it makes sense to take it out of the controllers. This cleans up the code and admits a more modular way of reading in our datasets |
colbyendres
force-pushed
the
move_home
branch
from
afa2696
to
dd10aa6
Compare
colbyendres
commented
Oct 22, 2024
|
|
||
| flash[:notice] = "Welcome back, #{@current_user.first_name}!" unless flash[:notice] || flash[:error] | ||
| redirect_to user_path(@current_user) | ||
| redirect_to schedules_path |
colbyendres
changed the title
Naviunni
reviewed
Oct 23, 2024
| @@ -1,6 +1,6 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| require 'csv' | |||
| # require_relative '../services/csv_handler' | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the home page after login is the index for
user. This isn't useful, so change it to land onschedulesinstead.