Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room Time Slot Matrix Added #43

Merged
merged 13 commits into from
Oct 30, 2024
Merged

Room Time Slot Matrix Added #43

merged 13 commits into from
Oct 30, 2024

Conversation

wahibkapdi
Copy link
Collaborator

Rubocop - 25 offenses
Coverage -
Unit - 93%
Cucumber - 89% (Missing Coverage in Time Slots)

@colbyendres
Copy link
Collaborator

Are we intending RoomBookings#index to be the landing page for the finished schedule or is this just for creating locked courses? If the latter, I think this table structure should be duplicated to represent the final schedule. Our scheduling algorithm could then just populate @bookings_matrix with a string containing course, section, and professor

@wahibkapdi
Copy link
Collaborator Author

Are we intending RoomBookings#index to be the landing page for the finished schedule or is this just for creating locked courses? If the latter, I think this table structure should be duplicated to represent the final schedule. Our scheduling algorithm could then just populate @bookings_matrix with a string containing course, section, and professor

We are populating RoomBookings#index with finished schedule. As generating the schedule is just going to be an intermediate step as the client keeps iterating over the schedules.

@colbyendres
Copy link
Collaborator

colbyendres commented Oct 30, 2024

We are populating RoomBookings#index with finished schedule. As generating the schedule is just going to be an intermediate step as the client keeps iterating over the schedules.

That seems reasonable to me. We'll have the Generate Schedule button on Schedule#index redirect to this page whenever the algorithm finishes.

@wahibkapdi wahibkapdi merged commit 7a96b6d into main Oct 30, 2024
2 checks passed
@wahibkapdi wahibkapdi deleted the wahibkapdi-gridview branch October 31, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants