Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix issue where the configuration was not being loaded before actions were performed #539

Merged
merged 1 commit into from
Apr 22, 2024
Merged

fix: fix issue where the configuration was not being loaded before actions were performed #539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions idea-plugin/src/main/kotlin/com/itangcent/idea/plugin/config/EnhancedConfigReader.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,11 @@ class EnhancedConfigReader : BaseConfigReader() {
contextSwitchListener.onModuleChange {
loadConfigList()
}
//fix: https://github.com/tangcent/easy-yapi/issues/1121
//if the module is null, the contextSwitchListener will not be triggered
if (contextSwitchListener.getModule() == null) {
loadConfigList()
}
} finally {
notInit = false
}
Expand Down
7 changes: 7 additions & 0 deletions ...dea.plugin.config.EnhancedConfigReaderTest.EmptyRecommendEnhancedConfigReaderTest.log.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,10 @@

If you need to enable the built-in recommended configuration.Go to [Preference -> Other Setting -> EasyApi -> Recommend]
[DEBUG] load remote config
[TRACE] No config be found
[DEBUG] use built-in config
[DEBUG] use recommend config
[DEBUG] Even useRecommendConfig was true, but no recommend config be selected!

If you need to enable the built-in recommended configuration.Go to [Preference -> Other Setting -> EasyApi -> Recommend]
[DEBUG] load remote config
4 changes: 4 additions & 0 deletions ...ngcent.idea.plugin.config.EnhancedConfigReaderTest.SimpleEnhancedConfigReaderTest.log.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,7 @@
[DEBUG] use built-in config
[DEBUG] use recommend config
[DEBUG] load remote config
[TRACE] No config be found
[DEBUG] use built-in config
[DEBUG] use recommend config
[DEBUG] load remote config
Loading