Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update methods in ScriptRuleParser to avoid return types with parameter type erasure #558

Merged
merged 1 commit into from
Jan 1, 2025

Conversation

tangcent
Copy link
Owner

@tangcent tangcent commented Jan 1, 2025

No description provided.

@tangcent tangcent added the type: bug Something isn't working label Jan 1, 2025
Copy link

codecov bot commented Jan 1, 2025

Codecov Report

Attention: Patch coverage is 40.07937% with 151 lines in your changes missing coverage. Please review.

Project coverage is 63.798%. Comparing base (38d384d) to head (e8ecc2e).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...com/itangcent/idea/plugin/rule/ScriptRuleParser.kt 40.079% 111 Missing and 40 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##              master      #558       +/-   ##
===============================================
- Coverage     63.802%   63.798%   -0.004%     
+ Complexity      2034      2032        -2     
===============================================
  Files            224       224               
  Lines          11462     11447       -15     
  Branches        2584      2579        -5     
===============================================
- Hits            7313      7303       -10     
+ Misses          2805      2797        -8     
- Partials        1344      1347        +3     
Flag Coverage Δ
unittests 63.798% <40.079%> (-0.004%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...com/itangcent/idea/plugin/rule/ScriptRuleParser.kt 51.675% <40.079%> (-0.519%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38d384d...e8ecc2e. Read the comment docs.

@tangcent tangcent merged commit 2763a75 into master Jan 1, 2025
10 checks passed
@tangcent tangcent mentioned this pull request Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant