fix: site replication of bucket deletion sync (minio#352)

Bucket deletion timestamp was not being passed back in GetBucketInfo, which is needed to decide on the bucket creation/deletion
taran-p · Feb 4, 2025 · 4df7a3a · 4df7a3a
1 parent 64a8f2e
commit 4df7a3a
Show file tree

Hide file tree

Showing 4 changed files with 55 additions and 18 deletions.
diff --git a/cmd/peer-rest-server.go b/cmd/peer-rest-server.go
@@ -1308,6 +1308,7 @@ func (s *peerRESTServer) HeadBucketHandler(mss *grid.MSS) (info *VolInfo, nerr *
 	return &VolInfo{
 		Name:    bucketInfo.Name,
 		Created: bucketInfo.Created,
+		Deleted: bucketInfo.Deleted, // needed for site replication
 	}, nil
 }
 

diff --git a/cmd/peer-s3-client.go b/cmd/peer-s3-client.go
@@ -393,6 +393,7 @@ func (client *remotePeerS3Client) GetBucketInfo(ctx context.Context, bucket stri
 	return BucketInfo{
 		Name:    volInfo.Name,
 		Created: volInfo.Created,
+		Deleted: volInfo.Deleted,
 	}, nil
 }
 

diff --git a/cmd/storage-datatypes.go b/cmd/storage-datatypes.go
@@ -111,6 +111,9 @@ type VolInfo struct {
 
 	// total VolInfo counts
 	count int
+
+	// Date and time when the volume was deleted, if Deleted
+	Deleted time.Time
 }
 
 // FilesInfo represent a list of files, additionally

diff --git a/cmd/storage-datatypes_gen.go b/cmd/storage-datatypes_gen.go