Enable linting for graphql (#830)

Also fix existing warnings

Co-authored-by: Ilya Konyukhov <[email protected]>

.luacheckrc

@@ -8,8 +8,6 @@ include_files = {
 }
 exclude_files = {
     '.rocks',
-    'cartridge/graphql.lua',
-    'cartridge/graphql/*.lua',
 }
 new_read_globals = {
     box = { fields = {

cartridge/graphql.lua

@@ -56,7 +56,7 @@ local function add_callback_prefix(prefix, doc)
     local obj = {
         kind = kind,
         arguments = {},
-        resolve = function(self, args)
+        resolve = function()
             return {}
         end,
         description = doc,
@@ -79,7 +79,7 @@ local function add_mutation_prefix(prefix, doc)
     local obj = {
         kind = kind,
         arguments = {},
-        resolve = function(self, args)
+        resolve = function()
             return {}
         end,
         description = doc,

cartridge/graphql/execute.lua

@@ -71,7 +71,7 @@ local function mergeSelectionSets(fields)
   return selections
 end
 
-local function defaultResolver(object, arguments, info)
+local function defaultResolver(object, _, info)
   return object[info.fieldASTs[1].name.value]
 end
 
@@ -253,7 +253,7 @@ local function getFieldEntry(objectType, object, fields, context)
   end)
 
   --[[
-      Make arguments ordered map using metatble.
+      Make arguments ordered map using metatable.
       This way callback can use positions to access argument values.
       For example buisness logic depends on argument positions to choose
       appropriate storage iteration.

cartridge/graphql/introspection.lua

@@ -238,7 +238,7 @@ __Type = types.object({
 
       possibleTypes = {
         kind = types.list(types.nonNull(__Type)),
-        resolve = function(kind, arguments, context)
+        resolve = function(kind, _, context)
           if kind.__type == 'Interface' or kind.__type == 'Union' then
             return context.schema:getPossibleTypes(kind)
           end

cartridge/graphql/parse.lua

@@ -1,7 +1,7 @@
 _G._ENV = rawget(_G, "_ENV") -- to get lulpeg work under strict mode
 local lpeg = require 'lulpeg'
 local P, R, S, V = lpeg.P, lpeg.R, lpeg.S, lpeg.V
-local C, Ct, Cmt, Cg, Cc, Cf, Cmt = lpeg.C, lpeg.Ct, lpeg.Cmt, lpeg.Cg, lpeg.Cc, lpeg.Cf, lpeg.Cmt
+local C, Ct, Cmt = lpeg.C, lpeg.Ct, lpeg.Cmt
 
 local line
 local lastLinePos
@@ -261,8 +261,22 @@ local graphQL = P {
   definition = _'operation' + _'fragmentDefinition',
 
   operationType = C(P'query' + P'mutation'),
-  operation = (_'operationType' * ws * maybe(name) * maybe('variableDefinitions') * maybe('directives') * _'selectionSet' + _'selectionSet') / cOperation,
-  fragmentDefinition = 'fragment' * ws * fragmentName * ws * _'typeCondition' * ws * _'selectionSet' / cFragmentDefinition,
+  operation = (_'operationType'
+      * ws
+      * maybe(name)
+      * maybe('variableDefinitions')
+      * maybe('directives')
+      * _'selectionSet'
+      + _'selectionSet'
+    ) / cOperation,
+  fragmentDefinition = 'fragment'
+    * ws
+    * fragmentName
+    * ws
+    * _'typeCondition'
+    * ws
+    * _'selectionSet'
+    / cFragmentDefinition,
 
   selectionSet = ws * '{' * ws * list('selection') * ws * '}' / cSelectionSet,
   selection = ws * (_'field' + _'fragmentSpread' + _'inlineFragment'),
@@ -278,10 +292,20 @@ local graphQL = P {
   directive = '@' * name * maybe('arguments') / cDirective,
   directives = ws * list('directive', 1) * ws,
 
-  variableDefinition = ws * variable * ws * ':' * ws * _'type' * (ws * '=' * _'value') ^ -1 * comma * ws / cVariableDefinition,
+  variableDefinition = ws
+    * variable
+    * ws
+    * ':'
+    * ws
+    * _'type'
+    * (ws * '=' * _'value') ^ -1
+    * comma
+    * ws
+    / cVariableDefinition,
   variableDefinitions = ws * '(' * list('variableDefinition', 1) * ')',
 
-  value = ws * (variable + _'objectValue' + _'listValue' + enumValue + stringValue + booleanValue + floatValue + intValue),
+  value = ws
+    * (variable + _'objectValue' + _'listValue' + enumValue + stringValue + booleanValue + floatValue + intValue),
   listValue = '[' * list('value') * ']' / cList,
   objectFieldValue = ws * C(rawName) * ws * ':' * ws * _'value' * comma / cObjectField,
   objectValue = '{' * ws * list('objectFieldValue') * ws * '}' / cObject,

cartridge/graphql/query_util.lua

@@ -1,6 +1,5 @@
 local path = (...):gsub('%.[^%.]+$', '')
 local types = require(path .. '.types')
-local util = require(path .. '.util')
 
 local function typeFromAST(node, schema)
   local innerType

cartridge/graphql/rules.lua

@@ -186,7 +186,7 @@ function rules.unambiguousSelections(node, context)
   validateSelectionSet(node, context.objects[#context.objects])
 end
 
-function rules.uniqueArgumentNames(node, context)
+function rules.uniqueArgumentNames(node, _)
   if node.arguments then
     local arguments = {}
     for _, argument in ipairs(node.arguments) do
@@ -226,7 +226,7 @@ function rules.requiredArgumentsPresent(node, context)
   end
 end
 
-function rules.uniqueFragmentNames(node, context)
+function rules.uniqueFragmentNames(node, _)
   local fragments = {}
   for _, definition in ipairs(node.definitions) do
     if definition.kind == 'fragmentDefinition' then
@@ -348,7 +348,7 @@ function rules.fragmentSpreadIsPossible(node, context)
   end
 end
 
-function rules.uniqueInputObjectFields(node, context)
+function rules.uniqueInputObjectFields(node, _)
   local function validateValue(value)
     if value.kind == 'listType' or value.kind == 'nonNullType' then
       return validateValue(value.type)

cartridge/graphql/types.lua

@@ -296,7 +296,8 @@ end
 
 types.int = types.scalar({
   name = 'Int',
-  description = "The `Int` scalar type represents non-fractional signed whole numeric values. Int can represent values from -(2^31) to 2^31 - 1, inclusive.",
+  description = "The `Int` scalar type represents non-fractional signed whole numeric values. " ..
+                "Int can represent values from -(2^31) to 2^31 - 1, inclusive.",
   serialize = coerceInt,
   parseValue = coerceInt,
   parseLiteral = function(node)
@@ -309,7 +310,8 @@ types.int = types.scalar({
 
 types.long = types.scalar({
   name = 'Long',
-  description = "The `Long` scalar type represents non-fractional signed whole numeric values. Long can represent values from -(2^52) to 2^52 - 1, inclusive.",
+  description = "The `Long` scalar type represents non-fractional signed whole numeric values. " ..
+                "Long can represent values from -(2^52) to 2^52 - 1, inclusive.",
   serialize = coerceLong,
   parseValue = coerceLong,
   parseLiteral = function(node)
@@ -336,7 +338,8 @@ types.float = types.scalar({
 
 types.string = types.scalar({
   name = 'String',
-  description = "The `String` scalar type represents textual data, represented as UTF-8 character sequences. The String type is most often used by GraphQL to represent free-form human-readable text.",
+  description = "The `String` scalar type represents textual data, represented as UTF-8 character sequences. " ..
+                "The String type is most often used by GraphQL to represent free-form human-readable text.",
   serialize = tostring,
   parseValue = tostring,
   parseLiteral = function(node)

cartridge/graphql/validate.lua

@@ -27,7 +27,7 @@ local visitors = {
       end
     end,
 
-    children = function(node, context)
+    children = function(node, _)
       return node.definitions
     end,
 
@@ -41,7 +41,7 @@ local visitors = {
       context.variableReferences = {}
     end,
 
-    exit = function(node, context)
+    exit = function(_, context)
       table.remove(context.objects)
       context.currentOperation = nil
       context.variableReferences = nil
@@ -85,7 +85,7 @@ local visitors = {
       end
     end,
 
-    exit = function(node, context)
+    exit = function(_, context)
       table.remove(context.objects)
     end,
 
@@ -135,11 +135,11 @@ local visitors = {
       table.insert(context.objects, kind)
     end,
 
-    exit = function(node, context)
+    exit = function(_, context)
       table.remove(context.objects)
     end,
 
-    children = function(node, context)
+    children = function(node, _)
       if node.selectionSet then
         return {node.selectionSet}
       end
@@ -205,7 +205,7 @@ local visitors = {
       end
     end,
 
-    exit = function(node, context)
+    exit = function(_, context)
       table.remove(context.objects)
     end,
 
@@ -223,7 +223,7 @@ local visitors = {
       table.insert(context.objects, kind)
     end,
 
-    exit = function(node, context)
+    exit = function(_, context)
       table.remove(context.objects)
     end,
 
@@ -293,7 +293,7 @@ local visitors = {
   },
 
   directive = {
-    children = function(node, context)
+    children = function(node, _)
       return node.arguments
     end
   }