-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go-tupleconv: change the datetime conversion logic, improve tests #3
Conversation
ed5cf37
to
91bce95
Compare
91bce95
to
10469de
Compare
Pls, update changelog about changed date-time format and TZ support. |
converter.go
Outdated
ttTimeLayout = "2006-01-02T15:04:05.999999-0700" | ||
dateTimeLayout = "2006-01-02 15:04:05" | ||
dateOnlyLayout = "2006-01-02" | ||
dateLayout = "2006-01-02" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
dateLayout = "2006-01-02" | |
dateLayout = time.DateOnly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reworked, now only two required formats are supported by default:
- with numeric tz offset:
2006-01-02T15:04:05.999999999-0700
- with tz name:
2006-01-02T15:04:05.999999999 Europe/Moscow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the patch!
10469de
to
ffb27fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patch. lgtm
- Supported time layouts have been modified to be more strict. - Added the ability to specify time zone name in datetime.
ffb27fe
to
bf21e8f
Compare
Datetime
conversion logic changes:Other:
MakeStringToTTConvFactory
.