Free resources in error cases

tarantool · Dec 22, 2021 · 202fbbe · 202fbbe
1 parent c52df71
commit 202fbbe
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/kafka/callbacks.c b/kafka/callbacks.c
@@ -156,13 +156,15 @@ rebalance_msg_t *new_rebalance_revoke_msg(rd_kafka_topic_partition_list_t *revok
 
     pthread_mutex_t lock;
     if (pthread_mutex_init(&lock, NULL) != 0) {
+        free(msg);
         return NULL;
     }
 
     msg->lock = lock;
 
     pthread_cond_t sync;
     if (pthread_cond_init(&sync, NULL) != 0) {
+        free(msg);
         return NULL;
     }
 
@@ -181,13 +183,15 @@ rebalance_msg_t *new_rebalance_assign_msg(rd_kafka_topic_partition_list_t *assig
 
     pthread_mutex_t lock;
     if (pthread_mutex_init(&lock, NULL) != 0) {
+        free(msg);
         return NULL;
     }
 
     msg->lock = lock;
 
     pthread_cond_t sync;
     if (pthread_cond_init(&sync, NULL) != 0) {
+        free(msg);
         return NULL;
     }
 
@@ -206,13 +210,15 @@ rebalance_msg_t *new_rebalance_error_msg(rd_kafka_resp_err_t err) {
 
     pthread_mutex_t lock;
     if (pthread_mutex_init(&lock, NULL) != 0) {
+        free(msg);
         return NULL;
     }
 
     msg->lock = lock;
 
     pthread_cond_t sync;
     if (pthread_cond_init(&sync, NULL) != 0) {
+        free(msg);
         return NULL;
     }
 

diff --git a/kafka/queue.c b/kafka/queue.c
@@ -107,6 +107,7 @@ new_queue() {
 
     pthread_mutex_t lock;
     if (pthread_mutex_init(&lock, NULL) != 0) {
+        free(queue);
         return NULL;
     }