Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: dont os.exit() in session disconnect trigger #223

Merged
merged 1 commit into from
Dec 15, 2023
Merged

test: dont os.exit() in session disconnect trigger #223

merged 1 commit into from
Dec 15, 2023

Commits on Dec 15, 2023

  1. test: dont os.exit() in session disconnect trigger 

    We are going to make Tarantool shutdown graceful. Particularly for
iproto graceful shutdown we wait while all connections are finished.
On connection disconnect session disconnect triggers are invoked. If
trigger hangs then graceful shutdown will hang too. And os.exit() do
hang, it sleeps forever.

So 110-disconnect-trigger-check.t test now hangs with iproto graceful
shutdown patch.

Making os.exit() from disconnect trigger does not seem as a product
case. So let's just change the test not to use os.exit().

Required for full-ci pass of tarantool/tarantool#9457
    @nshy
    nshy committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    0e2ec1d View commit details
    Browse the repository at this point in the history