Skip to content

Commit

Permalink
ci: overwrite tmpdir in mac integration tests
Browse files Browse the repository at this point in the history
The test `test_t3_instance_names_no_config` always fails because of very
long path in tmpdir. This test requires socket path with fexed length,
otherwise it can cause socket path buffer overflow.

After the patch tmpdir was overwritten to the shorter one.

Closes #931
  • Loading branch information
themilchenko committed Oct 9, 2024
1 parent 69af6a9 commit 0107fb9
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 3 deletions.
5 changes: 4 additions & 1 deletion .github/workflows/full-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -201,8 +201,11 @@ jobs:
- name: Run unit tests
run: mage unitfull

# We need to override TMPDIR here because of the very long path in macOS tests
# which causes a very long socket path error.
- name: Integration tests
run: mage integrationfull
# run: TMPDIR=/tmp mage integrationfull
run: python3 -m pytest -m "not slow_ee" test/integration/pack -v -s

# Etcd can be still running after integration tests when:
# 1. pytest recieve SIGALRM (can be caused by pytest-timeout plugin)
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -197,8 +197,10 @@ jobs:
- name: Unit tests
run: mage unit

# We need to override TMPDIR here because of the very long path in macOS tests
# which causes a very long socket path error.
- name: Run integration tests
run: mage integration
run: TMPDIR=/tmp mage integration

# Etcd can be still running after integration tests when:
# 1. pytest recieve SIGALRM (can be caused by pytest-timeout plugin)
Expand Down
2 changes: 1 addition & 1 deletion magefile.go
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,7 @@ func IntegrationFull() error {
fmt.Println("Running all integration tests...")

return sh.RunV(pythonExecutableName, "-m", "pytest", "-m", "not slow_ee and not notarantool",
"test/integration")
"test/integration", "-s")
}

// Run full set of integration tests, excluding docker tests.
Expand Down

0 comments on commit 0107fb9

Please sign in to comment.