Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aeon: connect implementation #1065

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

aeon: connect implementation #1065

wants to merge 4 commits into from
+6,684 −132

Conversation

dmyger
Copy link
Collaborator

@dmyger dmyger commented Dec 12, 2024

Mock server Implement some base methods for integration tests.

Part of #1050

@oleg-jukovec oleg-jukovec marked this pull request as draft December 13, 2024 10:13
@dmyger dmyger force-pushed the dmyger/gh-1050-aeon-connect-implementation branch from e743db4 to 4e6f784 Compare December 13, 2024 11:31
@dmyger dmyger force-pushed the dmyger/gh-1048-aeon-connect-dummy-implementation branch from ba43ee0 to 7c44fea Compare December 13, 2024 12:49
@dmyger dmyger force-pushed the dmyger/gh-1050-aeon-connect-implementation branch from 4e6f784 to 90c3018 Compare December 13, 2024 12:51
@dmyger dmyger force-pushed the dmyger/gh-1048-aeon-connect-dummy-implementation branch from 7c44fea to 6f2cdc8 Compare December 13, 2024 13:08
@dmyger dmyger force-pushed the dmyger/gh-1050-aeon-connect-implementation branch from 90c3018 to f6a666b Compare December 13, 2024 13:09
Base automatically changed from dmyger/gh-1048-aeon-connect-dummy-implementation to master December 16, 2024 07:02
@dmyger dmyger force-pushed the dmyger/gh-1050-aeon-connect-implementation branch 10 times, most recently from 8a3c46a to 4151819 Compare December 23, 2024 15:07
@dmyger dmyger force-pushed the dmyger/gh-1050-aeon-connect-implementation branch 2 times, most recently from 75ee5c5 to 81f879f Compare December 26, 2024 13:26
@oleg-jukovec oleg-jukovec added the full-ci Enables full ci tests label Dec 27, 2024
@dmyger dmyger force-pushed the dmyger/gh-1050-aeon-connect-implementation branch from 81f879f to 243e95c Compare December 27, 2024 13:46
@dmyger dmyger marked this pull request as ready for review December 27, 2024 13:47
@dmyger dmyger force-pushed the dmyger/gh-1050-aeon-connect-implementation branch 3 times, most recently from 40a246a to b09a2db Compare December 27, 2024 16:45
@dmyger dmyger removed the full-ci Enables full ci tests label Dec 27, 2024
@dmyger dmyger force-pushed the dmyger/gh-1050-aeon-connect-implementation branch 2 times, most recently from 903da6a to 543f89a Compare December 27, 2024 16:53
@dmyger dmyger force-pushed the dmyger/gh-1050-aeon-connect-implementation branch 6 times, most recently from 84a305e to 75fc2c9 Compare December 28, 2024 12:29
@dmyger dmyger added the full-ci Enables full ci tests label Dec 28, 2024
@dmyger dmyger force-pushed the dmyger/gh-1050-aeon-connect-implementation branch 2 times, most recently from 344b475 to 3cc50af Compare December 28, 2024 12:40
oleg-jukovec
oleg-jukovec reviewed Dec 28, 2024
View reviewed changes
.gitmodules Show resolved Hide resolved
cli/aeon/cmd/connect.go Outdated Show resolved Hide resolved
cli/aeon/generate-pb.sh Outdated Show resolved Hide resolved
test/integration/aeon/generate-keys.sh Outdated Show resolved Hide resolved
cli/aeon/client.go Outdated Show resolved Hide resolved
cli/console/format.go
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add tests.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks still relevant.

cli/console/handler.go Outdated Show resolved Hide resolved
cli/console/handler.go Outdated Show resolved Hide resolved
cli/console/history.go Outdated Show resolved Hide resolved
cli/console/history.go Show resolved Hide resolved
@oleg-jukovec
Copy link
Contributor

Please, add a CHANGELOG.md entry and a TarantoolBot comment too.

@dmyger dmyger force-pushed the dmyger/gh-1050-aeon-connect-implementation branch from 3cc50af to ec39731 Compare January 10, 2025 16:13
@dmyger dmyger requested a review from oleg-jukovec January 10, 2025 16:13
dmyger added 3 commits January 13, 2025 18:55
@dmyger
aeon: use submodule for aeon .proto scheme
3d554a4
@dmyger
ci: remove extra environment preparations
ea167db 
prepare-[ce|ee]-test-env - fixed preparing test requirements.
static-code-check - removed extra steps what was did on previous steps.

Changes are needed to adjust the CI/CD settings to match
their step name. Which in turn allows you to properly manage the order
of actions during the build testing.
@dmyger
aeon: mock gRPC server
e844f27 
Mock server Implement some base methods for integration tests.

Part of #1050, #1049
@dmyger dmyger force-pushed the dmyger/gh-1050-aeon-connect-implementation branch 3 times, most recently from 0c9e45f to 8c3fb45 Compare January 13, 2025 19:05
@dmyger dmyger requested a review from oleg-jukovec January 13, 2025 19:05
@oleg-jukovec
Copy link
Contributor

oleg-jukovec commented Jan 13, 2025 •
edited
Loading

Please, fix the linter errors and red CI.

oleg-jukovec
oleg-jukovec reviewed Jan 13, 2025
View reviewed changes
cli/aeon/results.go
}
return output
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment missed.

oleg-jukovec
oleg-jukovec reviewed Jan 13, 2025
View reviewed changes
cli/aeon/results_export_test.go
Comment on lines +5 to +10
func NewResultType(names []string, rows []ResultRow) ResultType {
return ResultType{
names: names,
rows: rows,
}
}
Copy link
Contributor

@oleg-jukovec oleg-jukovec Jan 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we just to add the constructor into the public API?

oleg-jukovec
oleg-jukovec reviewed Jan 13, 2025
View reviewed changes
cli/console/history.go
)

const (
DefaultHistoryFileName = ".tarantool_history"
Copy link
Contributor

@oleg-jukovec oleg-jukovec Jan 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do separate history files are used for Tarantool and aeon?

@dmyger
aeon: connect implementation
d34e71d 
Implement aeon console connection.

The ‘Console’ module has been separate from the ‘Connect’ abstraction,
to allow it being used independently of the transport layer.

Closes #1050

@TarantoolBot document
Title: Implement aeon console connection.

Command allow connect to Enterprise Aeon database with specified URL.
Available command options:
- `sslkeyfile <private_key>` - path to private part of certificate.
- `sslcertfile <pub_cert>` - path to public part of certificate.
- `sslcafile <ca_file>` - path to root CA for self-signed certificate.
- `transport [ssl|plain]` - connection mode.
@dmyger dmyger force-pushed the dmyger/gh-1050-aeon-connect-implementation branch from 8c3fb45 to d34e71d Compare January 14, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-jukovec oleg-jukovec oleg-jukovec left review comments

@patapenka-alexey patapenka-alexey Awaiting requested review from patapenka-alexey

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
full-ci Enables full ci tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmyger @oleg-jukovec