update #6
Closed
update #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…19884) titan's grip, unequip with full bags
…#19947) fix(Scripts/BlackTemple): Fix variable not being set to false when Akama dies
…of Azzinoth (#19967) fix(Scripts/Core): fix blaze and flame bast casting for Flame of Azzinoth
…#19948) * fix(Scripts/BlackTemple): fix stationary shadow demons * optimization: use else if to stop the execution when a condition is reach * revert last changes and fix the spell to allow move while casting * .
tarawow
pushed a commit
that referenced
this pull request
Sep 14, 2024
Revert "Split Ulduar's script files"
#19944) * fix(Scripts/BlackTemple): Parasitic Shadowfiends should not target players affected with debuff * Update boss_illidan.cpp * Update src/server/scripts/Outland/BlackTemple/boss_illidan.cpp * make it simple
#19946) * fix(Scripts/BlackTemple): Implement emotes when opening Najentus and Den of Mortal Delights * only check if state is done
Referenced commit(s): 8b16f7d
* fix(Scripts/BT): correct illidari council enrage timer * wrong conversion from 5ae1473 * redundant
#19962) * fix(Core/PlayerQuest): Introduce flag QUEST_SPECIAL_FLAGS_NO_LOREMASTER_COUNT - this allows flagging quests so that they will not count towards Loremaster achievement - update Corrupted Flower Quests in Felwood accordingly as a first use case * load Specialflags as uint32 from DB
Referenced commit(s): e2353a1
Revert "fix(Core/Spells): Resolve a case of triggered spells prolonging comba…" This reverts commit edd7e10.
Referenced commit(s): 07c54fe
…19968) fix(Scripts/BlackTemple): fix the charge mechanic of Flames of Azzinoth * remove also a old duplicate check in a spell script
…t. (#19991) * Revert "fix(Core/Spells): Revert triggered spell logic change. (#19983)" This reverts commit 3bb5ec7. * Add aura effect check. Co-Authored-By: Anton Popovichenko <[email protected]> * Add comment, use target instead of owner. * Adjust comment terminology. --------- Co-authored-by: Anton Popovichenko <[email protected]>
Try to fix bug with loot
…ng (#19957) * fix(DB/Creature) Black Temple - Illidari Assassin: Riposte ability missing * fix(DB/Creature): Black Temple - Illidari Assassin: Riposte ability missing * Update 2024_09_13_00.sql * bitwise method
Referenced commit(s): 1d899cf
… version. (#19997) * fix(CI/MacOS): Fix MacOS CI dependency installation. * Try to use macos 14 version * Remove brew cleanup and z3 dependency * Adjust readline lib discovery * Update macos supported version in SECURITY.md
…sage (#19926) * fix lance requirement error msg * ;
Referenced commit(s): 188b864
* remove weird blanks * update if * ) ) to )) * missed some ) ) * now switch * .
* fix(Core/AllMapScript) Update structure to use CALL_ENABLED_HOOKS * fatal error: no template named 'vector' in namespace 'std' * fix build Co-authored-by: Anton Popovichenko <[email protected]> --------- Co-authored-by: Anton Popovichenko <[email protected]>
* fix(DB/Creature) Ebon Blade Commander Equipment * fix(DB/Creature) Ebon Blade Commander Equipment * Update rev_1725226115559982400.sql * Update rev_1725226115559982400.sql ---------
…#20004) * Init. * Correct wrong query characters.
Referenced commit(s): 1802de9
Referenced commit(s): 985410f
* fix(DB/quest_offer_reward): C'Thun's Legacy turnin dialogue * fix(DB/quest_offer_reward): C'Thun's Legacy turnin dialogue
Referenced commit(s): 44a10e7
* fix(DB/Creature): chances items changed * fix: edit items chances and set GroupId
Referenced commit(s): 8dc0827
…tId to creature_text (#18611) * (Instance:Pit of Saron) cleanup some duplicated txt lines and make use broadcast_text for localization support (Instance:AzjolNerub) added ruRU creature_text localization for Anub'arak intro (because BroadcastTextId unknown) * Update txt_line_fix.sql Remove excess line breaks * Rescued Alliance Slave connect heroic version template --------- Co-authored-by: Walter Pagani <[email protected]>
Referenced commit(s): 8566e4a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Proposed:
This PR proposes changes to:
Issues Addressed:
SOURCE:
The changes have been validated through:
Tests Performed:
This PR has been:
How to Test the Changes:
Known Issues and TODO List:
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.