Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relocated Gamma ray notebook to docs/contributing/in_progress/nebulaโ€ฆ #2961

Closed
wants to merge 3 commits into from

Conversation

rudrakshnalbalwar
Copy link

@rudrakshnalbalwar rudrakshnalbalwar commented Jan 27, 2025

๐Ÿ“ Description

Type: ๐Ÿ“ documentation

Moved Gamma ray notebook to /docs/contributing/in_progress/nebular_phase as mentioned in issue #2766

๐Ÿ“Œ Resources

Examples, notebooks, and links to useful references.

๐Ÿšฆ Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

โ˜‘๏ธ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@tardis-bot
Copy link
Contributor

tardis-bot commented Jan 27, 2025

*beep* *bop*

Hi, human.

The docs workflow has failed โŒ

Click here to see the build log.

@tardis-bot
Copy link
Contributor

tardis-bot commented Jan 27, 2025

*beep* *bop*
Hi human,
I ran ruff on the latest commit (529cca3).
Here are the outputs produced.
Results can also be downloaded as artifacts here.
Summarised output:

4	W291	[*] Trailing whitespace
3	F401	[*] `astropy.constants` imported but unused
2	I001	[*] Import block is un-sorted or un-formatted
1	E999	[ ] SyntaxError: Expected an expression
1	W292	[*] No newline at end of file
1	W605	[*] Invalid escape sequence: `\g`

Complete output(might be large):

.mailmap:1:38: E999 SyntaxError: Expected an expression
.mailmap:294:49: W292 [*] No newline at end of file
docs/contributing/in_progress/nebular_phase/working_gamma_ray_test.ipynb:cell 1:2:1: I001 [*] Import block is un-sorted or un-formatted
docs/contributing/in_progress/nebular_phase/working_gamma_ray_test.ipynb:cell 1:3:18: F401 [*] `pandas` imported but unused
docs/contributing/in_progress/nebular_phase/working_gamma_ray_test.ipynb:cell 1:6:29: F401 [*] `astropy.constants` imported but unused
docs/contributing/in_progress/nebular_phase/working_gamma_ray_test.ipynb:cell 1:7:25: F401 [*] `astropy.units` imported but unused
docs/contributing/in_progress/nebular_phase/working_gamma_ray_test.ipynb:cell 2:2:1: I001 [*] Import block is un-sorted or un-formatted
docs/contributing/in_progress/nebular_phase/working_gamma_ray_test.ipynb:cell 7:5:70: W291 [*] Trailing whitespace
docs/contributing/in_progress/nebular_phase/working_gamma_ray_test.ipynb:cell 9:3:96: W291 [*] Trailing whitespace
docs/contributing/in_progress/nebular_phase/working_gamma_ray_test.ipynb:cell 9:4:99: W291 [*] Trailing whitespace
docs/contributing/in_progress/nebular_phase/working_gamma_ray_test.ipynb:cell 9:6:78: W291 [*] Trailing whitespace
docs/contributing/in_progress/nebular_phase/working_gamma_ray_test.ipynb:cell 10:2:65: W605 [*] Invalid escape sequence: `\g`
Found 12 errors.
[*] 11 fixable with the `--fix` option.

@rudrakshnalbalwar
Copy link
Author

Hi @atharva-2001 and @andrewfullard,

Could you please review this whenever you get a chance?

@wkerzendorf
Copy link
Member

Thanks for your PR this is something we are working on.

@Knights-Templars
Copy link
Member

Thanks for the contribution. But we are still working on this part and have not made any final decision as to where this notebook should be placed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants