Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add-isolation-levels #28

Merged
merged 6 commits into from
Oct 10, 2023
Merged

add-isolation-levels #28

merged 6 commits into from
Oct 10, 2023

Conversation

AlexCue987
Copy link
Contributor

overload withTransaction to accept one more parameter, isolation level

@AlexCue987 AlexCue987 requested a review from a team as a code owner September 29, 2023 19:25
@CLAassistant
Copy link

CLAassistant commented Sep 29, 2023 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ chad-moller-target
❌ Alex-Kuznetsov-Target
You have signed the CLA already but the status is still pending? Let us recheck it.

dtanner
dtanner reviewed Sep 29, 2023
View reviewed changes
Copy link
Contributor

@dtanner dtanner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - i had the one question on configuration. thanks @Alex-Kuznetsov-Target !

src/main/kotlin/com/target/liteforjdbc/Db.kt Show resolved Hide resolved
@bmuenzenmeyer
Copy link

@AlexCue987 @Alex-Kuznetsov-Target I am investigating the CLA assistant problems on my end - but please don't consider them blocking to this effort.

@chad-moller-target chad-moller-target merged commit e7ad85a into target:main Oct 10, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtanner dtanner dtanner left review comments

@chad-moller-target chad-moller-target chad-moller-target approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AlexCue987 @CLAassistant @bmuenzenmeyer @dtanner @chad-moller-target @Alex-Kuznetsov-Target