feat!: update payment id to cover all transaction types #6744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated `PaymentId::Open, AddressAndData, TransactionInfo` to reflect the transaction type for all defined types in `pub enum TxType`. - Fixed transaction identification for all defined types in `pub enum TxType`. - Added method `transaction_type_from_encrypted_data` to the wallet FFI and a unit test to test all cases. - Added wallet FFI test cases to ensure coin-join and coin-split transactions are correctly flagged in the payment ID.
hansieodendaal
changed the title
hansieodendaal
changed the title
Test Results (CI) 3 files 129 suites 36m 58s ⏱️ Results for commit ae4463c. ♻️ This comment has been updated with latest results. |
Test Results (Integration tests)36 tests 36 ✅ 19m 41s ⏱️ Results for commit ae4463c. ♻️ This comment has been updated with latest results. |
This was referenced Jan 17, 2025
SWvheerden
previously approved these changes
Jan 17, 2025
applications/minotari_console_wallet/src/ui/components/transactions_tab.rs
Outdated
Show resolved
Hide resolved
base_layer/core/src/transactions/transaction_components/encrypted_data.rs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PaymentId::Open,PaymentId::AddressAndDataandPaymentId::TransactionInfoto reflect the transaction type for all defined types inpub enum TxType.pub enum TxType.transaction_type_from_encrypted_datato the wallet FFI and a unit test to test all cases.TODO: System-level testing mobile wallet recovery into a view-only console wallet.
Close issues #6713 and #6745
Motivation and Context
The payment ID did not cover all transaction types or provide sufficient information for wallet recovery.
How Has This Been Tested?
What process can a PR reviewer use to test or verify this change?
Code review
System-level tests
Breaking Changes
BREAKING CHANGE:
fn transaction_type_from_encrypted_dataPaymentIdenum inEncryptedDatachanged:PaymentId::OpenchangedPaymentId::Addressfell awayPaymentId::AddressAndDatachangedPaymentId::TransactionInfochangedPaymentId::U64