Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add monerod fallback strategy #6764

Open
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

hansieodendaal
Copy link
Contributor

@hansieodendaal hansieodendaal commented Jan 27, 2025

Description

  • Added a monerod fallback strategy whereby static monerod responses can be loaded if monerod goes offline. Options are always use monerod, use static monerod responses when monerod goes offline, or always use static monerod responses. With this implementation, it is possible to merge mine offline from monerod.
  • Reduced the general connection monerod timeout from 5s to 2s; this improves overall monerod responsiveness in event of a monerod connection error.
  • Fixed a bug whereby the same monerod entry would be retried over and over in the event of a monerod connection error.

Closes #6756

Motivation and Context

This could improve merge mining with Tari Universe.

How Has This Been Tested?

System-level testing
Added unit tests

What process can a PR reviewer use to test or verify this change?

Code review
System-level testing

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

Copy link
Collaborator

@stringhandler stringhandler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear how this data is derived. Please add more context

Copy link

github-actions bot commented Jan 27, 2025

Test Results (CI)

    3 files    129 suites   37m 25s ⏱️
1 360 tests 1 360 ✅ 0 💤 0 ❌
4 078 runs  4 078 ✅ 0 💤 0 ❌

Results for commit 1ccc2aa.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jan 27, 2025

Test Results (Integration tests)

36 tests   36 ✅  21m 28s ⏱️
11 suites   0 💤
 2 files     0 ❌

Results for commit 1ccc2aa.

♻️ This comment has been updated with latest results.

@hansieodendaal hansieodendaal force-pushed the ho_monerod_empty_template branch from 57ab03a to 244620b Compare January 28, 2025 10:18
@hansieodendaal hansieodendaal marked this pull request as draft January 28, 2025 10:18
@hansieodendaal hansieodendaal force-pushed the ho_monerod_empty_template branch from 4fe0bed to 0911b91 Compare January 29, 2025 15:59
Added monerod fallback strategy whereby static monerod responses can be loaded
if monerod goes offline. Options are always use monerod, use static monerod
responses when monerod goes offline, or always use static monerod responses. With
this implementation it is possible to merge mine offline from monerod.
@hansieodendaal hansieodendaal force-pushed the ho_monerod_empty_template branch from 0911b91 to e555f31 Compare January 30, 2025 12:40
@hansieodendaal hansieodendaal marked this pull request as ready for review January 30, 2025 12:43
@hansieodendaal hansieodendaal requested a review from a team as a code owner January 30, 2025 12:43
Copy link
Collaborator

@SWvheerden SWvheerden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create empty block if monerod fails
3 participants