fix: wallet validation #6765
Merged
fix: wallet validation #6765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results (CI) 3 files 129 suites 35m 10s ⏱️ Results for commit 7d70edc. ♻️ This comment has been updated with latest results. |
Test Results (Integration tests) 2 files + 2 11 suites +11 39m 0s ⏱️ + 39m 0s For more details on these failures, see this check. Results for commit 7d70edc. ± Comparison against base commit 2535e87. ♻️ This comment has been updated with latest results. |
hansieodendaal
previously approved these changes
Jan 27, 2025
|
It will still finish, it wont revalidate outputs its already validated. And when this stops, it does not delete progress on validation it already made. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes wallet validation to always correctly trigger
Motivation and Context
Currently when a new block comes, validation is triggered, but if validation is already running, nothing happens. We need to stop the current validation as we need to validate with the newest information.
How Has This Been Tested?
Manual