Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Disable interactive payments for OSP QR #1251

Merged
merged 2 commits into from
Oct 30, 2024
Merged

feat: Disable interactive payments for OSP QR #1251

merged 2 commits into from
Oct 30, 2024

Conversation

igordanilcenko
Copy link
Contributor

  • Disabled the OSP switcher on the Add Amount screen if there is an address which is one-sided only
  • Added touch event animations for the Numpad
  • Moved the fee calculation logic from WalletService to FFIWallet
  • Fixed improper progress state while fee is being calculated

@igordanilcenko igordanilcenko self-assigned this Oct 30, 2024
@igordanilcenko igordanilcenko added this to the 1249 milestone Oct 30, 2024
@igordanilcenko igordanilcenko linked an issue Oct 30, 2024 that may be closed by this pull request
[TTL] Disable interactive payments for OSP QR #1249
Closed
0xoqurde
0xoqurde approved these changes Oct 30, 2024
View reviewed changes
Copy link

@0xoqurde 0xoqurde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@igordanilcenko igordanilcenko merged commit a43d5eb into development Oct 30, 2024
@igordanilcenko igordanilcenko deleted the feature/disable_osp_ttl branch October 30, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xoqurde 0xoqurde 0xoqurde approved these changes

Assignees

@igordanilcenko igordanilcenko

Labels
None yet
Projects
None yet
Milestone
1249
Development

Successfully merging this pull request may close these issues.

[TTL] Disable interactive payments for OSP QR
2 participants
@igordanilcenko @0xoqurde