Make the swisscard importer work with the new statement CSV format. #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somewhen between Jun 4th and Jul 5th, the swisscard statements in CSV format moved from a single Category column to: - a "Merchant Category" column, which looks like a general category for the merchant. - a "Registered Category" column, which looks like a string version of the ISO standard MCC code. Since all statements, previous and past, are now issued with the updated format, it's safe to just modify the importer to make use of the split columns as metadata.
|
I just created #112 as this is the first time to do changes since beancount 3 was released and for now I have to stick with beancount 2 (waiting for fava to upgrade first). Will get that PR merged soon, if you can rebase afterwards, it should hopefully resolve the issues you have on this PR. |
|
Just merged it, can you rebase please? and thank you for your contribution |
|
Sure thing, done. |
|
Merged, thank you very much, I'll trigger a release right away |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somewhen between Jun 4th and Jul 5th, the swisscard statements in CSV format moved from a single Category column to:
Since all statements, previous and past, are now issued with the updated format, it's safe to just modify the importer to make use of the split columns as metadata.