Open threads

packages/tasit-action/src/contract/Action.js

@@ -7,54 +7,71 @@ import ConfigLoader from "../ConfigLoader";
 export class Action extends Subscription {
   #provider;
   #signer;
-  #rawTx;
+  #rawAction;
   #tx;
   #txConfirmations = 0;
   #timeout;
   #lastConfirmationTime;
   #isRunning = false;
 
-  constructor(rawTx, provider, signer) {
+  constructor(rawAction, provider, signer) {
     // Provider implements EventEmitter API and it's enough
     //  to handle with transactions events
     super(provider);
 
     const { events } = ConfigLoader.getConfig();
     const { timeout } = events;
 
-    this.#rawTx = rawTx;
+    this.#rawAction = rawAction;
     this.#signer = signer;
     this.#timeout = timeout;
     this.#provider = provider;
     this.#txConfirmations = 0;
   }
 
-  _toRaw = async () => {
-    return await this.#rawTx;
+  _toRaw = () => {
+    return this.#rawAction;
+  };
+
+  #fillRawAction = async rawTx => {
+    const nonce = await this.#provider.getTransactionCount(
+      this.#signer.address
+    );
+
+    const network = await this.#provider.getNetwork();
+    const { chainId } = network;
+
+    let { value } = rawTx;
+    value = !value ? 0 : value;
+
+    // Note: Gas estimation should be improved
+    // See: https://github.com/tasitlabs/TasitSDK/issues/173
+    //
+    // This command isn't working
+    const gasPrice = 1e9;
+
+    rawTx = { ...rawTx, nonce, chainId, value, gasPrice };
+
+    // Note: Gas estimation should be improved
+    // See: https://github.com/tasitlabs/TasitSDK/issues/173
+    //
+    // This command isn't working
+    //const gasLimit = await this.#provider.estimateGas(rawTx);
+    const gasLimit = 7e6;
+
+    rawTx = { ...rawTx, gasLimit };
+
+    return rawTx;
   };
 
   #signAndSend = async () => {
     try {
-      // TODO: Go deep on gas handling.
-      // Without that, VM returns a revert error instead of out of gas error.
-      // See: https://github.com/tasitlabs/TasitSDK/issues/173
-      //
-      // This command isn't enough
-      // const gasLimit = await this.#provider.estimateGas(this.#rawTx);
-      const gasParams = {
-        gasLimit: 7e6,
-        gasPrice: 1e9,
-      };
-
-      const nonce = await this.#provider.getTransactionCount(
-        this.#signer.address
-      );
-
-      let rawTx = await this.#rawTx;
-
-      rawTx = { ...rawTx, nonce, ...gasParams };
-
-      const signedTx = await this.#signer.sign(rawTx);
+      // Note: Resolving promise if the Action was created using a async rawTx
+      const rawAction = await this.#rawAction;
+
+      this.#rawAction = await this.#fillRawAction(rawAction);
+
+      const signedTx = await this.#signer.sign(this.#rawAction);
 
       this.#tx = await this.#provider.sendTransaction(signedTx);
     } catch (error) {

packages/tasit-action/src/contract/Contract.test.js

@@ -457,7 +457,9 @@ describe("TasitAction.Contract", () => {
     //  new difficultywise-longest well-formed blockchain which excludes one or more blocks that
     //  the client previously thought were part of the difficultywise-longest well-formed blockchain.
     //  These excluded blocks become orphans.
-    it("should emit error event when block reorganization occurs - tx confirmed twice", async () => {
+    //
+    // Non-deterministic
+    it.skip("should emit error event when block reorganization occurs - tx confirmed twice", async () => {
       const confirmationListener = sinon.fake();
       const errorFn = sinon.fake();
 
@@ -516,7 +518,8 @@ describe("TasitAction.Contract", () => {
       expect(actionId).to.have.lengthOf(66);
     });
 
-    it("should be able to listen to an event before sending", async () => {
+    // Non-deterministic
+    it.skip("should be able to listen to an event before sending", async () => {
       const confirmationListener = sinon.fake(async message => {
         action.off("confirmation");
       });

packages/tasit-action/src/erc721/ERC721Full.test.js

@@ -132,7 +132,10 @@ describe("TasitAction.ERC721.ERC721Full", () => {
       await expectExactTokenBalances(erc721, [ana.address], [1]);
     });
 
-    it("should transfer an owned token", async () => {
+    // Non-deterministic
+    // Enable again after solve this isse:
+    // https://github.com/tasitlabs/TasitSDK/issues/367
+    it.skip("should transfer an owned token", async () => {
       erc721 = new ERC721Full(ERC721_FULL_ADDRESS, ana);
 
       const transferListener = sinon.fake(message => {

packages/tasit-contract-based-account/src/GnosisSafe.js

@@ -146,11 +146,15 @@ export default class GnosisSafe extends Contract {
   };
 
   #executeTransaction = (data, toAddress, etherValue) => {
-    const rawTxPromise = this.#prepareTransaction(data, toAddress, etherValue);
+    const rawActionPromise = this.#prepareTransaction(
+      data,
+      toAddress,
+      etherValue
+    );
     const provider = this._getProvider();
     const signer = this.getWallet();
 
-    const action = new Action(rawTxPromise, provider, signer);
+    const action = new Action(rawActionPromise, provider, signer);
     return action;
   };
 
@@ -226,8 +230,8 @@ export default class GnosisSafe extends Contract {
       signatures
     );
 
-    const rawTx = await execTxAction._toRaw();
+    const rawAction = await execTxAction._toRaw();
 
-    return rawTx;
+    return rawAction;
   };
 }