Skip to content

Commit

Permalink
remove frameworks that do not comply with the new TodoMVC guidelines (#…
Browse files Browse the repository at this point in the history
…1932)

* remove sammyjs

* remove kendo ui

* remove sapui

* remove socketstream example

* remove spinejs example

* remove vanilla dart example

* remove vanilla dart from circle.yml
  • Loading branch information
FadySamirSadek authored Aug 23, 2018
1 parent 1d25647 commit d698282
Show file tree
Hide file tree
Showing 115 changed files with 3 additions and 90,852 deletions.
2 changes: 0 additions & 2 deletions .jscsrc
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,7 @@
"examples/js_of_ocaml/js/*.js",
"examples/olives/olives-todo.js",
"examples/polymer/elements/elements.build.js",
"examples/spine/js/**",
"examples/typescript-*/js/**/*.js",
"examples/vanilladart/**/*.js",
"examples/vanilla-es6/dist/bundle.js"
],
"requireSpaceBeforeBlockStatements": true,
Expand Down
24 changes: 0 additions & 24 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -132,10 +132,6 @@ jobs:
env:
- CYPRESS_framework=jsblocks
<<: *defaults
- stage: test
env:
- CYPRESS_framework=kendo
<<: *defaults
- stage: test
env:
- CYPRESS_framework=knockback
Expand Down Expand Up @@ -188,26 +184,10 @@ jobs:
env:
- CYPRESS_framework=riotjs
<<: *defaults
- stage: test
env:
- CYPRESS_framework=sammyjs
<<: *defaults
- stage: test
env:
- CYPRESS_framework=sapui5
<<: *defaults
- stage: test
env:
- CYPRESS_framework=scalajs-react
<<: *defaults
- stage: test
env:
- CYPRESS_framework=socketstream
<<: *defaults
- stage: test
env:
- CYPRESS_framework=spine
<<: *defaults
- stage: test
env:
- CYPRESS_framework=typescript-angular
Expand All @@ -224,10 +204,6 @@ jobs:
env:
- CYPRESS_framework=vanilla-es6
<<: *defaults
- stage: test
env:
- CYPRESS_framework=vanilladart
<<: *defaults
- stage: test
env:
- CYPRESS_framework=vanillajs
Expand Down
15 changes: 0 additions & 15 deletions circle.yml
Original file line number Diff line number Diff line change
Expand Up @@ -68,14 +68,10 @@ jobs:
# compiled-to-js frameworks
kotlin-react:
<<: *defaults
spine:
<<: *defaults
typescript-react:
<<: *defaults
binding-scala:
<<: *defaults
vanilladart:
<<: *defaults
angular-dart:
<<: *defaults
serenadejs:
Expand All @@ -99,12 +95,8 @@ jobs:
<<: *defaults
canjs_require:
<<: *defaults
kendo:
<<: *defaults
rappidjs:
<<: *defaults
sapui5:
<<: *defaults
react-alt:
<<: *defaults
webrx:
Expand All @@ -113,8 +105,6 @@ jobs:
<<: *defaults
somajs_require:
<<: *defaults
sammyjs:
<<: *defaults
puremvc:
<<: *defaults
exoskeleton:
Expand Down Expand Up @@ -175,11 +165,9 @@ workflows:
# second tab - compiled-to-js frameworks
compiled-to-js:
jobs:
- spine
# elm is not working very well
- typescript-react
- binding-scala
- vanilladart
- angular-dart
- serenadejs
- js_of_ocaml
Expand All @@ -195,10 +183,7 @@ workflows:
jobs:
- chaplin-brunch
- canjs_require
- kendo
- rappidjs
# Sapui5 is too broken in layout
# - sapui5
- react-alt
# App internal error
# - webrx
Expand Down
3 changes: 0 additions & 3 deletions cypress/integration/spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ const frameworkFolders = {
'angular-dart': 'angular-dart/web',
'chaplin-brunch': 'chaplin-brunch/public',
duel: 'duel/www',
vanilladart: 'vanilladart/build/web'
}
const getExampleFolder = framework => frameworkFolders[framework] || framework

Expand All @@ -50,7 +49,6 @@ const noLocalStorageCheck = {
js_of_ocaml: true,
reagent: true,
rappidjs: true,
kendo: true,
exoskeleton: true,
'react-backbone': true,
puremvc: true,
Expand All @@ -60,7 +58,6 @@ const noLocalStorageCheck = {
}

const noLocalStorageSpyCheck = {
spine: true,
canjs: true,
canjs_require: true
}
Expand Down
9 changes: 0 additions & 9 deletions examples/kendo/bower.json

This file was deleted.

Loading

3 comments on commit d698282

@jbristowe
Copy link

@jbristowe jbristowe commented on d698282 Sep 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious to know why Kendo UI Core was removed from the list. From the new guidelines:

A good app that we are looking for should check most if not all of the items

Emphasis (above) by me. Kendo UI Core meets 4/5 of the requirements (i.e. <5K stars). Is there something I could tweak/improve/fix to have Kendo UI Core reinstated?

@FadySamirSadek
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbristowe The main reason the app was removed is that it was not updated for a long time and did not pass the tests. Since the app already existed on TodoMVC and Kendo UI is very known in the community I would be open to adding it back if you opened a PR that contains an updated version of the example that passes the test suite.
Thanks and apologies for not mentioning you or other team members before the removal, please tell me if there is anything I can help with.

@jbristowe
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's all good! Thanks for the follow up.

Please sign in to comment.